Skip to content

Revert "coin3d: 4.0.3 -> 4.0.4"#428028

Merged
JohnRTitor merged 1 commit intoNixOS:masterfrom
lonyelon:revert-420051-auto-update/coin3d
Aug 2, 2025
Merged

Revert "coin3d: 4.0.3 -> 4.0.4"#428028
JohnRTitor merged 1 commit intoNixOS:masterfrom
lonyelon:revert-420051-auto-update/coin3d

Conversation

@lonyelon
Copy link
Contributor

@lonyelon lonyelon commented Jul 24, 2025 •
edited
Loading

Reverts #420051

This change needs to be reverted as FreeCAD now crashes when creating and opening files, as well as when changing some settings, making the program unusable (FreeCAD/FreeCAD#22695).

@lonyelon
Copy link
Contributor Author

lonyelon commented Jul 24, 2025 •
edited
Loading

I will prettify this later but for now it is ok since I need this for freecad to work.

wolfgangwalther
wolfgangwalther previously requested changes Jul 24, 2025
View reviewed changes
Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the reason for revert to the commit message.

(if that's what you mean by "prettify", cool)

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Jul 24, 2025
@lonyelon
Copy link
Contributor Author

lonyelon commented Jul 24, 2025

(if that's what you mean by "prettify", cool)

Yes, sorry about the vague language, that is what I meant.

Since it is a bit urgent for me to have freecad working I prioritized testing above writing. As soon as I see it working normally I will update the PR accordingly.

If the test fails then I will close the PR, but everything points to this lib being the root cause of the crashes.

@lonyelon
Copy link
Contributor Author

lonyelon commented Jul 24, 2025

I had never experienced a full FreeCAD compilation...

@lonyelon lonyelon mentioned this pull request Jul 27, 2025
Open
2 tasks
@lonyelon lonyelon force-pushed the revert-420051-auto-update/coin3d branch from 1d26010 to 9bc2acc Compare July 27, 2025 18:29
@lonyelon
Copy link
Contributor Author

lonyelon commented Jul 27, 2025

I updated the branch since master was broken when I made the fork. Now I am waiting for freecad to build (it should probably finish by tomorrow).

@lonyelon
Copy link
Contributor Author

lonyelon commented Jul 27, 2025

@wolfgangwalther I confirm the issue is solved by the downgrade, FreeCAD is now working normally.

@lonyelon lonyelon requested a review from wolfgangwalther July 27, 2025 20:23
@lonyelon
Copy link
Contributor Author

lonyelon commented Jul 28, 2025

Archlinux already downgraded: https://archlinux.org/packages/extra/x86_64/coin/

@lonyelon lonyelon self-assigned this Jul 28, 2025
@lonyelon lonyelon added 0.kind: regression Something that worked before working no longer 1.severity: significant Novel ideas, large API changes, notable refactorings, issues with RFC potential, etc. and removed 1.severity: significant Novel ideas, large API changes, notable refactorings, issues with RFC potential, etc. labels Jul 28, 2025
@LordGrimmauld
Copy link
Contributor

LordGrimmauld commented Jul 29, 2025

Freecad crash report for nixpkgs in #429237

@LordGrimmauld LordGrimmauld mentioned this pull request Jul 29, 2025
Closed
3 tasks
LordGrimmauld
LordGrimmauld requested changes Jul 29, 2025
View reviewed changes
Copy link
Contributor

@LordGrimmauld LordGrimmauld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your revert commit message still does not document the reason for this revert. Please add that.

Other than this, seeing as #429237 is a thing and the revert fixes this, i would like to approve as the freecad maintainer. Just add the documentation please :)

@lonyelon
Revert "coin3d: 4.0.3 -> 4.0.4"
c3e01c8 
Reverts NixOS#420051 as FreeCAD now crashes when creating and opening files,
as well as when changing some settings, making the program unusable
(source FreeCAD/FreeCAD#22695).
@lonyelon lonyelon force-pushed the revert-420051-auto-update/coin3d branch from 9bc2acc to c3e01c8 Compare July 29, 2025 08:02
@lonyelon
Copy link
Contributor Author

lonyelon commented Jul 29, 2025

Your revert commit message still does not document the reason for this revert. Please add that.

Other than this, seeing as #429237 is a thing and the revert fixes this, i would like to approve as the freecad maintainer. Just add the documentation please :)

Changed, I had forgotten to edit the commit. Is that enough?

LordGrimmauld
LordGrimmauld approved these changes Jul 29, 2025
View reviewed changes
Copy link
Contributor

@LordGrimmauld LordGrimmauld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes thank you

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 29, 2025
@lonyelon lonyelon added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jul 31, 2025
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jul 31, 2025
@JohnRTitor JohnRTitor enabled auto-merge (rebase) August 2, 2025 15:49
@JohnRTitor
Copy link
Member

JohnRTitor commented Aug 2, 2025

Merging this for now @wolfgangwalther.

@JohnRTitor JohnRTitor merged commit 723ce93 into NixOS:master Aug 2, 2025
27 of 29 checks passed
@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented Aug 3, 2025

Thank you!

@mdaniels5757 mdaniels5757 mentioned this pull request Aug 16, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LordGrimmauld LordGrimmauld LordGrimmauld approved these changes

@wolfgangwalther wolfgangwalther Awaiting requested review from wolfgangwalther

Assignees

@lonyelon lonyelon

Labels

0.kind: regression Something that worked before working no longer 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lonyelon @LordGrimmauld @JohnRTitor @wolfgangwalther