Skip to content

gnucash: use webkitgtk_4_1, fix python support#428027

Merged
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
SuperSandro2000:gnucash-webgitkit
Jul 25, 2025
Merged

gnucash: use webkitgtk_4_1, fix python support#428027
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
SuperSandro2000:gnucash-webgitkit

Conversation

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jul 24, 2025

Need to run it on a graphical system to see if it actually works

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@SuperSandro2000 SuperSandro2000 marked this pull request as draft July 24, 2025 12:01
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Jul 24, 2025
@nix-owners nix-owners bot requested a review from nevivurn July 24, 2025 12:08
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 24, 2025
@SuperSandro2000 SuperSandro2000 changed the title gnucash: use webkitgtk_4_1 gnucash: use webkitgtk_4_1, fix python support Jul 24, 2025
@SuperSandro2000 SuperSandro2000 marked this pull request as ready for review July 24, 2025 21:35
@SuperSandro2000 SuperSandro2000 removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 24, 2025
 ➜ ./result/bin/gnucash
Traceback (most recent call last):
  File "/nix/store/1rm7rm8izpdyy8v53ybcr244hm010m07-gnucash-5.11/share/gnucash/python/init.py", line 6, in <module>
    from gi import require_version
ModuleNotFoundError: No module named 'gi'
Copy link
Member

@nevivurn nevivurn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 428027
Commit: 6df491d41ce74e0a3059d4119e3dfe3b8b4ad8c9


x86_64-linux

✅ 2 packages built:
  • gnucash (python313Packages.gnucash)
  • python312Packages.gnucash

Tested working, too.

@nevivurn nevivurn added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jul 25, 2025
@SuperSandro2000 SuperSandro2000 merged commit 44be3d1 into NixOS:master Jul 25, 2025
27 of 29 checks passed
@SuperSandro2000 SuperSandro2000 deleted the gnucash-webgitkit branch July 25, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants