ncurses: Recognise linux-gnuabielfv{1,2}#427495
Merged
flokli merged 1 commit intoNixOS:stagingfrom Jul 29, 2025
Merged
Conversation
Member
|
Upstream? |
Contributor
Author
|
Will do. Gah, more mailing lists… |
Contributor
Author
|
Submitted a report about this to upstream's ML, with a patch that fixes this written against their latest snapshot export: https://lists.gnu.org/archive/html/bug-ncurses/2025-07/msg00040.html Latest snapshot has some new spots in need of patching that didn't exist in the 6.5 release, so I'll vendor a backported version of the patch without those hunks here. Edit: Now included in v6_5_20250726: ThomasDickey/ncurses-snapshots@4afb0e7 |
e32fbf4 to
ed0971e
Compare
alyssais
approved these changes
Jul 26, 2025
Member
alyssais
left a comment
There was a problem hiding this comment.
Wonderful, thanks! (Please do proactively submit this sort of thing to upstream — the more each distro does that, the less work we all have to do.)
14 tasks
Member
|
Successfully built |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ncurses has a list of GNU-ish targets, for deciding which flags need to be set to get certain POSIX features.
linux-gnuabielfv{1,2}fails to match that list, so certain defines don't get set.This causes the build to fail for such targets, due to
wcwidthbeing gated in the system headers behind an_XOPEN_SOURCEcheck:Fix this issue by adding the pattern
linux*gnuabielfv*to the list.This makes (cross-)compiling
ncursesforpowerpc64-unknown-linux-gnuabielfv1work.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.