opensmalltalk-vm: don't throw without aliases#427246
Merged
philiptaron merged 1 commit intoNixOS:masterfrom Jul 21, 2025
Merged
opensmalltalk-vm: don't throw without aliases#427246philiptaron merged 1 commit intoNixOS:masterfrom
philiptaron merged 1 commit intoNixOS:masterfrom
Conversation
CI needs ugly workarounds to catch a `throw` on unsupported platforms. If aliases are disabled, as is the case in CI, we simply return `null` for this leaf package. This will ignore it for CI purposes, while still giving a proper error message for end users.
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
Contributor
|
Looks good to me! Thanks for this effort. I think it would also make sense to get rid of the error message and return an empty set: vmsByPlatform.${platform} or {}If there aren't any VMs on that platform, we just return no VMs. |
jbaum98
approved these changes
Jul 21, 2025
nixpkgs-ci
bot
added
the
12.approvals: 1
philiptaron
approved these changes
Jul 21, 2025
Contributor
Author
That would be considerably simpler, yes. Since this is already merged, if you'd like to put this up as a PR, feel free to ping me for review. |
Contributor
|
Successfully created backport PR for |
1 task
github-actions
bot
added
the
8.has: port to stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI needs ugly workarounds to catch a
throwon unsupported platforms. If aliases are disabled, as is the case in CI, we simply returnnullfor this leaf package. This will ignore it for CI purposes, while still giving a proper error message for end users.Similar solution to those in #426645.
Related: #426629.
Things done
Add a 👍 reaction to pull requests you find important.