Skip to content

byzanz: fix build with gettext 0.25#427190

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
jfly:fix-byzanz-build
Jul 22, 2025
Merged

byzanz: fix build with gettext 0.25#427190
Aleksanaa merged 1 commit intoNixOS:masterfrom
jfly:fix-byzanz-build

Conversation

@jfly
Copy link
Contributor

@jfly jfly commented Jul 21, 2025

I am far from an autotools expert, but this does make the package
compile again. I cobbled this together from various workarounds posted
on #405793.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

I am far from an autotools expert, but this does make the package
compile again. I cobbled this together from various workarounds posted
on <NixOS#405793>.
@jfly
Copy link
Contributor Author

jfly commented Jul 21, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 427190
Commit: f7624f3cf50d0af7f05b7bc3302b9f52b0c25adc


x86_64-linux

✅ 2 packages built:
  • byzanz
  • yaxg

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Jul 21, 2025
@nix-owners nix-owners bot requested a review from Bot-wxt1221 July 21, 2025 16:41
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jul 22, 2025
@Aleksanaa Aleksanaa merged commit 7d26323 into NixOS:master Jul 22, 2025
30 of 32 checks passed
@jfly jfly deleted the fix-byzanz-build branch July 22, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants