{clang,gcc}_multi: remove manual throws#426902
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Jul 21, 2025
Merged
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
This comment was marked as outdated.
This comment was marked as outdated.
wolfgangwalther
force-pushed
the
ci-eval-asserts-multi
branch
from
262d15d to
52b5960
Compare
wolfgangwalther
changed the title
wolfgangwalther
force-pushed
the
ci-eval-asserts-multi
branch
from
52b5960 to
7ee6939
Compare
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
wolfgangwalther
commented
Jul 21, 2025
wolfgangwalther
force-pushed
the
ci-eval-asserts-multi
branch
from
7ee6939 to
48c858e
Compare
wolfgangwalther
changed the title
This avoids hacky workarounds in CI when generating attrpaths for non-x86_64-linux platforms. Evaluation for these two attributes will not succeed on platforms other than Linux anyway, because: - The unsupported system error from `glibc-nolibgcc` is propagated. - `pkgsi686Linux.gcc` triggers an assert anyway.
wolfgangwalther
force-pushed
the
ci-eval-asserts-multi
branch
from
48c858e to
63e69e4
Compare
Member
|
This makes sense to me. GCC NG will also improve this situation. |
Contributor
|
Successfully created backport PR for |
1 task
github-actions
bot
added
the
8.has: port to stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids hacky workarounds in CI when generating attrpaths for non-x86_64-linux platforms.
Evaluation for these two attributes will not succeed on platforms other than Linux anyway, because:
glibc-nolibgccis propagated.pkgsi686Linux.gcctriggers an assert anyway.Related: #426629.
Similar to #426645.
Things done
Add a 👍 reaction to pull requests you find important.