odamex: 0.9.5 -> 11.0.0#426898
Conversation
|
@NixOS/nixpkgs-merge-bot merge |
|
worth a shot, thank you robot |
|
Bump - needs reviewer |
There was a problem hiding this comment.
No need to bump for reviewers. Someone will always get to reviewing a package.
odamex and odasrv work, but odalaunch returns this for me:
(odalaunch:38565): GLib-GIO-ERROR **: 06:47:40.157: No GSettings schemas are installed on the system
Trace/breakpoint trap (core dumped)
[ble: exit 133]
May want to take the desktop entries snippets from another existing PR: #388093
Also looks like Darwin stuff isn't being updated:
nixpkgs-review result for #426898
Generated using nixpkgs-review-gha
Command: nixpkgs-review pr 426898
Logs: https://github.com/keenanweaver/nixpkgs-review-gha/actions/runs/16399893213
x86_64-linux
✅ 1 package built:
- odamex
aarch64-linux
✅ 1 package built:
- odamex
x86_64-darwin
✅ No rebuilds
aarch64-darwin
✅ No rebuilds
|
thank you, yes that would be because we use wxGTK32 which needs a gsettings schema, I can fix that right now. However I do not use darwin so I have just assumed the build process was the same, should I just drop darwin? |
Ideally someone on Darwin would review this and add the fix. But it should be safe to drop. I can't imagine there are a lot of odamex players using the nixpkgs package on Darwin. |
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.