Skip to content

odamex: 0.9.5 -> 11.0.0#426898

Closed
yuria256 wants to merge 0 commit intoNixOS:masterfrom
yuria256:master
Closed

odamex: 0.9.5 -> 11.0.0#426898
yuria256 wants to merge 0 commit intoNixOS:masterfrom
yuria256:master

Conversation

@yuria256
Copy link
Copy Markdown

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and others READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 12.first-time contribution This PR is the author's first one; please be gentle! 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jul 20, 2025
@yuria256
Copy link
Copy Markdown
Author

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Copy Markdown
Contributor

@yuria256 merge not permitted (#305350):
CommitterPR: pr author is not committer
R-Ryantm Maintainer merge: pr author is not r-ryantm

@yuria256
Copy link
Copy Markdown
Author

worth a shot, thank you robot

@yuria256
Copy link
Copy Markdown
Author

Bump - needs reviewer

Copy link
Copy Markdown
Member

@keenanweaver keenanweaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to bump for reviewers. Someone will always get to reviewing a package.

odamex and odasrv work, but odalaunch returns this for me:

(odalaunch:38565): GLib-GIO-ERROR **: 06:47:40.157: No GSettings schemas are installed on the system
Trace/breakpoint trap (core dumped)
[ble: exit 133]

May want to take the desktop entries snippets from another existing PR: #388093

Also looks like Darwin stuff isn't being updated:

nixpkgs-review result for #426898

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 426898

Logs: https://github.com/keenanweaver/nixpkgs-review-gha/actions/runs/16399893213


x86_64-linux

✅ 1 package built:
  • odamex

aarch64-linux

✅ 1 package built:
  • odamex

x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jul 21, 2025
@yuria256
Copy link
Copy Markdown
Author

thank you, yes that would be because we use wxGTK32 which needs a gsettings schema, I can fix that right now. However I do not use darwin so I have just assumed the build process was the same, should I just drop darwin?

@keenanweaver
Copy link
Copy Markdown
Member

thank you, yes that would be because we use wxGTK32 which needs a gsettings schema, I can fix that right now. However I do not use darwin so I have just assumed the build process was the same, should I just drop darwin?

Ideally someone on Darwin would review this and add the fix. But it should be safe to drop. I can't imagine there are a lot of odamex players using the nixpkgs package on Darwin.

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 9, 2025
@yuria256 yuria256 closed this Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants