lima: fix guestagents resolvement with resolve-argv0#426377
Closed
BeiyanYunyi wants to merge 1 commit intoNixOS:masterfrom
Closed
lima: fix guestagents resolvement with resolve-argv0#426377BeiyanYunyi wants to merge 1 commit intoNixOS:masterfrom
BeiyanYunyi wants to merge 1 commit intoNixOS:masterfrom
Conversation
Member
|
Does 1.2.0 not fix the problem? #423960 Personally I didn't against this problem even used 1.1.1 in my NixOS and macOS+home-manager. Are you using nix-darwin likely #419596? |
Author
Tested, 1.2.0 fixed the problem. |
Member
|
Thanks for your testing and feedbacks 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to its code, lima uses argv0 to determine the
share/limafolder's route, which causes error in nix whenlimactlin PATH is a soft-link.Using an empty
--argv0inmakeWrapperwill set the real executable as argv0, which solves the issue.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.