extractpdfmark: fix build with gettext 0.25

[TomaSajt]

Related: #405793

touch config.rpath no longer seems to be needed after applying the patch. Not sure why...

I also added strictDeps = true; too and moved the test dependencies into their proper place.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
• NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

---

Add a 👍 reaction to pull requests you find important.

[gador]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 425806
Commit: f754332301d564c2b456d122da352295d6f9c428

---

x86_64-linux

✅ 24 packages built:

• asciidoc-full
• asciidoc-full-with-plugins
• asciidoc-full-with-plugins.dist
• asciidoc-full.dist
• clevis
• clevis.man
• denemo
• disorderfs
• extractpdfmark
• frescobaldi
• frescobaldi.dist
• rep (kakounePlugins.rep)
• lilypond
• lilypond-unstable
• lilypond-unstable-with-fonts
• lilypond-with-fonts
• luksmeta
• python312Packages.jianpu-ly
• python312Packages.jianpu-ly.dist
• python313Packages.jianpu-ly
• python313Packages.jianpu-ly.dist
• solfege
• tang
• tang.man

[phaer]

Oh my, for some reason i didn't find this via search, but saw it in the thread just as I was about to post a separate PR there after pushing.

Thanks! LGTM and fixes the build.

[TomaSajt]

The darwin build still seems to be failing with an error about missing iconv symbols...
I'll try to look into it.

[TomaSajt]

I had to set env.NIX_LDFLAGS = "-liconv" to fix it. Uhhh... I have no idea why. It built fine before.

In any case I don't have a lot of time now, so if anyone wants to open a PR for it, please do.

[mjohnson9]

I'm getting a failure on Linux.

Last 19 log lines:
┃        > Running phase: unpackPhase
┃        > unpacking source archive /nix/store/m75lqgskfmxs5kyqbqsrjlhih530i4sb-source
┃        > source root is source
┃        > Running phase: patchPhase
┃        > Running phase: autoreconfPhase
┃        > autoreconf: export WARNINGS=
┃        > autoreconf: Entering directory '.'
┃        > autoreconf: configure.ac: not using Gettext
┃        > autoreconf: running: aclocal --force -I m4
┃        > configure.ac:184: warning: macro 'AM_ICONV' not found in library
┃        > autoreconf: configure.ac: tracing
┃        > autoreconf: configure.ac: not using Libtool
┃        > autoreconf: configure.ac: not using Intltool
┃        > autoreconf: configure.ac: not using Gtkdoc
┃        > autoreconf: running: /nix/store/0qmqybsb86p5g6vqxj992grj9hyh72wa-autoconf-2.72/bin/autoconf --force
┃        > configure.ac:184: error: possibly undefined macro: AM_ICONV
┃        >       If this token and others are legitimate, please use m4_pattern_allow.
┃        >       See the Autoconf documentation.
┃        > autoreconf: error: /nix/store/0qmqybsb86p5g6vqxj992grj9hyh72wa-autoconf-2.72/bin/autoconf failed with exit status: 1

[TomaSajt]

I'm getting a failure on Linux.

Last 19 log lines:
┃        > Running phase: unpackPhase
┃        > unpacking source archive /nix/store/m75lqgskfmxs5kyqbqsrjlhih530i4sb-source
┃        > source root is source
┃        > Running phase: patchPhase
┃        > Running phase: autoreconfPhase
┃        > autoreconf: export WARNINGS=
┃        > autoreconf: Entering directory '.'
┃        > autoreconf: configure.ac: not using Gettext
┃        > autoreconf: running: aclocal --force -I m4
┃        > configure.ac:184: warning: macro 'AM_ICONV' not found in library
┃        > autoreconf: configure.ac: tracing
┃        > autoreconf: configure.ac: not using Libtool
┃        > autoreconf: configure.ac: not using Intltool
┃        > autoreconf: configure.ac: not using Gtkdoc
┃        > autoreconf: running: /nix/store/0qmqybsb86p5g6vqxj992grj9hyh72wa-autoconf-2.72/bin/autoconf --force
┃        > configure.ac:184: error: possibly undefined macro: AM_ICONV
┃        >       If this token and others are legitimate, please use m4_pattern_allow.
┃        >       See the Autoconf documentation.
┃        > autoreconf: error: /nix/store/0qmqybsb86p5g6vqxj992grj9hyh72wa-autoconf-2.72/bin/autoconf failed with exit status: 1

Are you testing on unstable?
This PR has only recently been merged into master and has not reached unstable yet.

[mjohnson9]

Oh, indeed, I am using unstable. Sorry, I don't quite understand how nixpkgs works and just searched for recent changes to extractpdfmark.