Skip to content

plausible: 2.1.5 -> 3.0.1#425757

Merged
onny merged 3 commits intoNixOS:masterfrom
xanderio:push-sxvqvvpkpkzr
Aug 12, 2025
Merged

plausible: 2.1.5 -> 3.0.1#425757
onny merged 3 commits intoNixOS:masterfrom
xanderio:push-sxvqvvpkpkzr

Conversation

@xanderio
Copy link
Contributor

Needs to be rebased after #423137 hits master.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 16, 2025
@onny
Copy link
Contributor

onny commented Jul 26, 2025

We should additionally move plausible derivation to pkgs/by-name and modernize with lib; usage in meta

@stepbrobd
Copy link
Member

Just curious if anything needs to change in the module?

Release note indicated CLICKHOUSE_SKIP_USER_SETUP needs to be set

@xanderio
Copy link
Contributor Author

Just curious if anything needs to change in the module?

Release note indicated CLICKHOUSE_SKIP_USER_SETUP needs to be set

That seems to be specific for the clickhouse container in their docker compose setup. I don't think this is relevant to us in this case.

@xanderio xanderio marked this pull request as ready for review August 11, 2025 14:35
@nix-owners nix-owners bot requested review from blitz and snue August 11, 2025 14:40
Copy link
Member

@snue snue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Thanks for moving the package and fixing the with lib; usage as well.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Aug 12, 2025
@onny
Copy link
Contributor

onny commented Aug 12, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 425757
Commit: 23a50c47d3606aa7931f868a3f456c82c0bb4e0e


x86_64-linux

✅ 1 package built:
  • plausible

@onny
Copy link
Contributor

onny commented Aug 12, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 425757 --package nixosTests.plausible
Commit: 23a50c47d3606aa7931f868a3f456c82c0bb4e0e


x86_64-linux

✅ 1 test built:
  • nixosTests.plausible

@onny onny merged commit bdb3cd9 into NixOS:master Aug 12, 2025
28 of 32 checks passed
@onny
Copy link
Contributor

onny commented Aug 12, 2025

Thank you!

@xanderio xanderio deleted the push-sxvqvvpkpkzr branch August 12, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants