Conversation
|
We should additionally move plausible derivation to |
|
Just curious if anything needs to change in the module? Release note indicated CLICKHOUSE_SKIP_USER_SETUP needs to be set |
af3cad4 to
ddc1eb1
Compare
That seems to be specific for the clickhouse container in their docker compose setup. I don't think this is relevant to us in this case. |
ddc1eb1 to
23a50c4
Compare
snue
left a comment
There was a problem hiding this comment.
Changes LGTM. Thanks for moving the package and fixing the with lib; usage as well.
|
|
|
Thank you! |
Needs to be rebased after #423137 hits master.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.