curlMinimal: 8.14.1 -> 8.16.0#425701
Merged
vcunat merged 2 commits intoNixOS:stagingfrom Sep 19, 2025
Merged
Conversation
Member
Author
|
All tests passed on x86_64-linux. |
3 tasks
Member
|
Curl 8.16.0 has been released in the mean time https://daniel.haxx.se/blog/2025/09/10/curl-8-16-0/ |
0fb2e0d to
fc43376
Compare
Member
Author
|
Fixes low severity CVE-2025-9086 CVE-2025-10148 |
vcunat
requested changes
Sep 18, 2025
Member
vcunat
left a comment
There was a problem hiding this comment.
This breaks cmake build, so you can't even build curl.
In file included from /build/cmake-3.31.7/Utilities/cm3p/curl/curl.h:8,
from /build/cmake-3.31.7/Source/CTest/cmCTestCurl.h:12,
from /build/cmake-3.31.7/Source/CTest/cmCTestCurl.cxx:3:
/build/cmake-3.31.7/Source/CTest/cmCTestCurl.cxx: In member function 'void cmCTestCurl::SetProxyType()':
/build/cmake-3.31.7/Source/CTest/cmCTestCurl.cxx:267:25: error: invalid conversion from 'long int' to 'curl_proxytype' [-fpermissive]
267 | this->HTTPProxyType = CURLPROXY_HTTP;
| ^~~~~~~~~~~~~~
| |
| long int
Member
Author
|
I had only built curlMinimal because I didn't have access to my workstation for a while. I'll take a look! |
fc43376 to
85bf1ac
Compare
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
https://daniel.haxx.se/blog/2025/07/16/curl-8-15-0/ https://curl.se/ch/8.15.0.html https://github.com/curl/curl/releases/tag/curl-8_15_0 https://daniel.haxx.se/blog/2025/07/16/curl-8-16-0/ https://curl.se/ch/8.16.0.html https://github.com/curl/curl/releases/tag/curl-8_16_0 Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
85bf1ac to
63dbf8e
Compare
vcunat
added a commit
that referenced
this pull request
Sep 19, 2025
Member
|
This seems to have broken curlWithGnuTls. |
Member
Author
|
Fixed in #444638 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://daniel.haxx.se/blog/2025/07/16/curl-8-15-0/
https://curl.se/ch/8.15.0.html
https://github.com/curl/curl/releases/tag/curl-8_15_0
https://daniel.haxx.se/blog/2025/07/16/curl-8-16-0/
https://curl.se/ch/8.16.0.html
https://github.com/curl/curl/releases/tag/curl-8_16_0
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.