Skip to content

python3Packages.fabric: fix build#425543

Merged
katexochen merged 1 commit intoNixOS:masterfrom
sarahec:fabric-fix-build
Jul 16, 2025
Merged

python3Packages.fabric: fix build#425543
katexochen merged 1 commit intoNixOS:masterfrom
sarahec:fabric-fix-build

Conversation

@sarahec
Copy link
Contributor

@sarahec sarahec commented Jul 15, 2025

  1. Build from github source
  2. Disabled two outdated tests

Filed fabric/fabric#2341

Found in nixpkgs-review of #409698

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

Build from github source, disable two outdated tests
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jul 15, 2025
@katexochen
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 425543
Commit: 3ef5cc311650f366cfa59904e5f672621f4d0db1


x86_64-linux

✅ 13 packages built:
  • Fabric (python313Packages.fabric)
  • Fabric.dist (python313Packages.fabric.dist)
  • awsebcli
  • awsebcli.dist
  • azure-cli
  • azure-cli.dist
  • python312Packages.coiled
  • python312Packages.coiled.dist
  • python312Packages.fabric
  • python312Packages.fabric.dist
  • python313Packages.coiled
  • python313Packages.coiled.dist
  • vscode-extensions.ms-azuretools.vscode-bicep

Copy link
Contributor

@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jul 16, 2025
@katexochen katexochen merged commit f201b8f into NixOS:master Jul 16, 2025
30 of 32 checks passed
@sarahec sarahec deleted the fabric-fix-build branch July 16, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants