Skip to content

Conversation

@guylamar2006
Copy link
Contributor

@guylamar2006 guylamar2006 commented Jul 15, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 15, 2025
Copy link
Contributor

@faukah faukah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do the migration and your changes in seperate commits. Looks pretty good otherwise.

@guylamar2006 guylamar2006 force-pushed the migrate-gazelle-origin branch 4 times, most recently from 99880dd to c2c4840 Compare July 17, 2025 00:59
@guylamar2006 guylamar2006 force-pushed the migrate-gazelle-origin branch from c2c4840 to 5f36419 Compare July 17, 2025 13:42
@guylamar2006
Copy link
Contributor Author

@bloxx12 I separated the migration and refactor commits.

@wegank wegank merged commit 90208f0 into NixOS:master Jul 23, 2025
26 of 27 checks passed
@guylamar2006 guylamar2006 deleted the migrate-gazelle-origin branch July 28, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants