oraclejdk: do not strip regular files from install dir

[lostdj]

Otherwise it removes src.zip, while those additional readme and license files won't harm anyone.

[edolstra]

Nix packages should not pollute the top-level directory. That's why these files were removed. A better solution is to do what the openjdk Nix expression does, namely, put everything in $out/lib/openjdk (with some symlinks like $out/bin).

[lostdj]

We can leave src.zip and remove everything else, how about that?

[Eternity-Yarr]

oracle jdk without src.zip is like "enable expert mode" button :)

[edolstra]

OpenJDK has src.zip:

$ nix-build '<nixpkgs>' -A openjdk
$ ll ./result/lib/openjdk/
total 22268                                                                                                                                                                                   
-r--r--r-- 1 root root     1503 Jan  1  1970 ASSEMBLY_EXCEPTION                                                                                                                               
dr-xr-xr-x 2 root root     4096 Jan  1  1970 bin                                                                                                                                              
dr-xr-xr-x 3 root root     4096 Jan  1  1970 jre                                                                                                                                              
dr-xr-xr-x 3 root root     4096 Jan  1  1970 lib                                                                                                                                              
-r--r--r-- 1 root root    19263 Jan  1  1970 LICENSE                                                                                                                                          
-r--r--r-- 1 root root       80 Jan  1  1970 release                                                                                                                                          
-r--r--r-- 1 root root 22578529 Jan  1  1970 src.zip                                                                                                                                          
-r--r--r-- 1 root root   172252 Jan  1  1970 THIRD_PARTY_README

The OracleJDK Nix expression should follow the same layout.

[nathan-gs]

+1
I don't think this change will break things. Maybe take into account the changes in #4541

[Fuuzetsu]

No response from author for a long time, please open a new PR if you're still interested in this.