Skip to content

Revert "Merge pull request #42376 from dtzWill/update/git-2.18.0"#42549

Merged
dtzWill merged 1 commit intoNixOS:masterfrom
dtzWill:fix/revert-git-2.18.0-update
Jun 25, 2018
Merged

Revert "Merge pull request #42376 from dtzWill/update/git-2.18.0"#42549
dtzWill merged 1 commit intoNixOS:masterfrom
dtzWill:fix/revert-git-2.18.0-update

Conversation

@dtzWill
Copy link
Member

@dtzWill dtzWill commented Jun 25, 2018

This reverts commit 2624f90, reversing
changes made to 37aab4c.

See:
#42376 (comment)

Basically this breaks at least some users of fetchgit,
so let's revert this until this is sorted out.

Breakage.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

This reverts commit 2624f90, reversing
changes made to 37aab4c.

See:
NixOS#42376 (comment)

Basically this breaks at least some users of fetchgit,
so let's revert this until this is sorted out.
@dtzWill dtzWill merged commit ee46b71 into NixOS:master Jun 25, 2018
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants