Skip to content

bitwarden-desktop: Build desktop proxy#425477

Merged
adamcstephens merged 1 commit intoNixOS:masterfrom
alexyao2015:fix/bitwarden-auth
Aug 26, 2025
Merged

bitwarden-desktop: Build desktop proxy#425477
adamcstephens merged 1 commit intoNixOS:masterfrom
alexyao2015:fix/bitwarden-auth

Conversation

@alexyao2015
Copy link
Contributor

Add desktop_proxy to $out/bin and patches bitwarden code to find the desktop proxy.

This reworks #374068 to address comments and remove the extra manifest additions since those are generated by the bitwarden app itself.

fixes #347350
closes #374068

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 15, 2025
@nix-owners nix-owners bot requested a review from amarshall July 15, 2025 15:47
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 27, 2025
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 28, 2025
@alexyao2015 alexyao2015 force-pushed the fix/bitwarden-auth branch 2 times, most recently from c194142 to d4cf260 Compare August 22, 2025 16:20
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 22, 2025
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 25, 2025
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 26, 2025
@SuperSandroBot
Copy link

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 425477
Commit: 875383a0e559c59182dbfbf0cc6c2784060b517c (subsequent changes)
Merge: 69a98e458d13b599303be76dd6ce096b7c6ccebc

Logs: https://github.com/SuperSandro2000/nixpkgs-review-gha/actions/runs/17224180178


x86_64-linux

✅ 1 package built:
  • bitwarden-desktop

aarch64-linux

✅ 1 package built:
  • bitwarden-desktop

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • bitwarden-desktop

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • bitwarden-desktop

@adamcstephens adamcstephens merged commit b3ce5da into NixOS:master Aug 26, 2025
30 of 32 checks passed
@alexyao2015 alexyao2015 deleted the fix/bitwarden-auth branch August 26, 2025 07:43
@alexyao2015 alexyao2015 restored the fix/bitwarden-auth branch August 26, 2025 07:44
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/bitwarden-unlock-with-system-authentication-on-nixos/68643/1

@nyabinary
Copy link
Contributor

nyabinary commented Sep 1, 2025

~> /nix/store/ff59lis9h6m4p9516frzx42in2a61ss5-bitwarden-desktop-2025.8.1/libexec/desktop_proxy
19:30:08 [INFO] Starting Bitwarden IPC Proxy.
19:30:08 [INFO] Process args: []
19:30:08 [INFO] Attempting to connect to /home/nyan/.cache/com.bitwarden.desktop/app.bitwarden
19:30:08 [ERROR] IPC client connection error: No such file or directory (os error 2)

Getting this for some reason (I tried running the desktop proxy manually after seeing it didn't work and got this error)

EDIT: Ignore that, got that fixed but for some reason the app doesn't get the prompt to enable fingerprinting even though I enabled the integration on both sides?

@g0r3
Copy link

g0r3 commented Sep 18, 2025

I have the same problem as @nyabinary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bitwarden-desktop: work with firefox.nativeMessagingHosts

8 participants