haskellPackages.mason: unbreak#425403
Conversation
|
Hey, thanks for the contribution! Ideally you could run Also maybe you can put a date and the affected mason version in the comment. Bonus points for adding a link to an upstream issue about the restrictive upper bound. |
|
@4z3 are you still interested in going forward with this PR? |
|
@wolfgangwalther sure. I've ran |
(generated by maintainers/scripts/haskell/regenerate-hackage-packages.sh)
a7cb308 to
5260d68
Compare
|
There was already an upstream PR, which had been merged but no revision / release made: fumieval/mason#14 I adjusted the comments accordingly and added a "warn after version" thing, because this will surely be fixed whenever there is a new version released. I also fixed the commit message for the first commit - this was not a |
wolfgangwalther
left a comment
There was a problem hiding this comment.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 425403
Commit: a7cb308cabcf812284c2246d2fca4a446a40a09e
x86_64-linux
✅ 3 packages built:
- haskell.package-list
- haskellPackages.mason
- haskellPackages.mason.doc
aarch64-linux
✅ 3 packages built:
- haskell.package-list
- haskellPackages.mason
- haskellPackages.mason.doc
x86_64-darwin
✅ 3 packages built:
- haskell.package-list
- haskellPackages.mason
- haskellPackages.mason.doc
aarch64-darwin
✅ 3 packages built:
- haskell.package-list
- haskellPackages.mason
- haskellPackages.mason.doc
|
@wolfgangwalther thanks |
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.