Skip to content

haskellPackages.mason: unbreak#425403

Merged
wolfgangwalther merged 2 commits intoNixOS:masterfrom
4z3:unbreak-mason
Oct 13, 2025
Merged

haskellPackages.mason: unbreak#425403
wolfgangwalther merged 2 commits intoNixOS:masterfrom
4z3:unbreak-mason

Conversation

@4z3
Copy link
Contributor

@4z3 4z3 commented Jul 15, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: haskell General-purpose, statically typed, purely functional programming language labels Jul 15, 2025
@maralorn
Copy link
Member

maralorn commented Jul 16, 2025

Hey, thanks for the contribution!

Ideally you could run maintainers/scripts/haskell/regenerate-hackage-packages.sh as part of your commit.

Also maybe you can put a date and the affected mason version in the comment. Bonus points for adding a link to an upstream issue about the restrictive upper bound.

@wolfgangwalther
Copy link
Contributor

@4z3 are you still interested in going forward with this PR?

@4z3
Copy link
Contributor Author

4z3 commented Oct 13, 2025

@wolfgangwalther sure. I've ran maintainers/scripts/haskell/regenerate-hackage-packages.sh and updated the PR to also tell the date. I haven't checked which exact mason versions are affected, but looking at the history of pkgs/development/haskell-modules/configuration-common.nix, this doesn't seem to be an information usually added anyway. Also I haven't check if there's any upstream issue.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 13, 2025
4z3 added 2 commits October 13, 2025 19:14
(generated by
maintainers/scripts/haskell/regenerate-hackage-packages.sh)
@wolfgangwalther
Copy link
Contributor

There was already an upstream PR, which had been merged but no revision / release made: fumieval/mason#14

I adjusted the comments accordingly and added a "warn after version" thing, because this will surely be fixed whenever there is a new version released.

I also fixed the commit message for the first commit - this was not a nixfmt issue, but a previous PR that didn't run the script after adding a maintainer. The change is not just formatting, but actually adds a maintainer.

Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 425403
Commit: a7cb308cabcf812284c2246d2fca4a446a40a09e


x86_64-linux

✅ 3 packages built:
  • haskell.package-list
  • haskellPackages.mason
  • haskellPackages.mason.doc

aarch64-linux

✅ 3 packages built:
  • haskell.package-list
  • haskellPackages.mason
  • haskellPackages.mason.doc

x86_64-darwin

✅ 3 packages built:
  • haskell.package-list
  • haskellPackages.mason
  • haskellPackages.mason.doc

aarch64-darwin

✅ 3 packages built:
  • haskell.package-list
  • haskellPackages.mason
  • haskellPackages.mason.doc

@4z3
Copy link
Contributor Author

4z3 commented Oct 13, 2025

@wolfgangwalther thanks

@wolfgangwalther wolfgangwalther added this pull request to the merge queue Oct 13, 2025
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 13, 2025
Merged via the queue into NixOS:master with commit b3a7907 Oct 13, 2025
29 of 32 checks passed
@4z3 4z3 deleted the unbreak-mason branch October 13, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants