Skip to content

1password: fix sha256 hash#42539

Merged
xeji merged 2 commits intoNixOS:masterfrom
marsam:feature/1password-fix-hash
Jun 25, 2018
Merged

1password: fix sha256 hash#42539
xeji merged 2 commits intoNixOS:masterfrom
marsam:feature/1password-fix-hash

Conversation

@marsam
Copy link
Contributor

@marsam marsam commented Jun 24, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 24, 2018
@xeji xeji merged commit be9240b into NixOS:master Jun 25, 2018
@jb55
Copy link
Contributor

jb55 commented Jun 25, 2018

uhh since this is a password manager, was there any investigation as to why the hash was changed?

@grahamc
Copy link
Member

grahamc commented Jun 25, 2018

@xeji did you test this change prior to merging? I'm surprised nobody called ofborg.

@xeji
Copy link
Contributor

xeji commented Jun 25, 2018 via email

@xeji
Copy link
Contributor

xeji commented Jun 25, 2018 via email

@jb55
Copy link
Contributor

jb55 commented Jun 25, 2018

I've verified the new hashes, the binaries are signed with the op signing key: https://keybase.io/1password

Please confirm that this has been done before merging, for future hash changes!

Thanks :)

@xeji
Copy link
Contributor

xeji commented Jun 25, 2018

@jb55 checking code signatures manually before merging would be a pain since each tarball needs to be unpacked first. It makes more sense to check the signature automatically during build.
I give that a try in #42580.

@marsam marsam deleted the feature/1password-fix-hash branch June 25, 2018 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants