1password: fix sha256 hash#42539
Merged
xeji merged 2 commits intoNixOS:masterfrom Jun 25, 2018
marsam:feature/1password-fix-hash
Merged
1password: fix sha256 hash#42539xeji merged 2 commits intoNixOS:masterfrom marsam:feature/1password-fix-hash
xeji merged 2 commits intoNixOS:masterfrom
marsam:feature/1password-fix-hash
Conversation
Contributor
|
uhh since this is a password manager, was there any investigation as to why the hash was changed? |
Member
|
@xeji did you test this change prior to merging? I'm surprised nobody called ofborg. |
Contributor
|
@grahamc it's unfree. I built it locally before merging.
|
Contributor
|
@grahamc it would be great if ofborg allowed building unfree packages so we could check all architectures before merging. Shouldn't be a license issue if the result doesn't leave the builder's local nix store.
|
Contributor
|
I've verified the new hashes, the binaries are signed with the op signing key: https://keybase.io/1password Please confirm that this has been done before merging, for future hash changes! Thanks :) |
9 tasks
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)