Skip to content

mpdris2-rs: init at 1.0.2#425185

Merged
philiptaron merged 2 commits intoNixOS:masterfrom
acid-bong:init/mpdris2-rs
Aug 26, 2025
Merged

mpdris2-rs: init at 1.0.2#425185
philiptaron merged 2 commits intoNixOS:masterfrom
acid-bong:init/mpdris2-rs

Conversation

@acid-bong
Copy link
Contributor

https://github.com/szclsya/mpdris2-rs

It's basically a Rust™ rewrite/reimplementation of mpd-mpris and mpDris2

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Jul 14, 2025
@acid-bong acid-bong marked this pull request as ready for review July 15, 2025 04:08
@acid-bong acid-bong marked this pull request as draft July 15, 2025 09:25
@acid-bong acid-bong marked this pull request as ready for review July 15, 2025 14:11
@acid-bong
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 425185

Logs: https://github.com/acid-bong/nixpkgs-review-gha/actions/runs/16597859163


x86_64-linux

✅ 1 package built:
  • mpdris2-rs

aarch64-linux

✅ 1 package built:
  • mpdris2-rs

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • mpdris2-rs

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • mpdris2-rs

@Sigmanificient
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 425185
Commit: 837380723888f7c64df4671a4b5a999e030df83f


x86_64-linux

✅ 1 package built:
  • mpdris2-rs

@acid-bong acid-bong marked this pull request as draft August 24, 2025 06:21
@acid-bong
Copy link
Contributor Author

huh, I even rebased against the latest master, and it still fails to download https://github.com/szclsya/mpdris2-rs/archive/refs/tags/1.0.2.tar.gz:

source> trying https://github.com/szclsya/mpdris2-rs/archive/refs/tags/1.0.2.tar.gz
source>   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
source>                                  Dload  Upload   Total   Spent    Left  Speed
source>   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
source>   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
source> curl: (22) The requested URL returned error: 404

@acid-bong
Copy link
Contributor Author

ah shit, the dev prepends a "v" now

@acid-bong acid-bong changed the title mpdris2-rs: init at 1.0.1 mpdris2-rs: init at 1.0.2 Aug 24, 2025
@acid-bong acid-bong marked this pull request as ready for review August 24, 2025 06:52
@acid-bong
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 425185
Commit: 9ab4929950d034b780afb037bb22548362afb96a (subsequent changes)
Merge: 0f26dbadf364d45a38a7fce931678143f52a050d

Logs: https://github.com/acid-bong/nixpkgs-review-gha/actions/runs/17185518021


x86_64-linux

✅ 1 package built:
  • mpdris2-rs

aarch64-linux

✅ 1 package built:
  • mpdris2-rs

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • mpdris2-rs

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • mpdris2-rs

@philiptaron

This comment was marked as outdated.

@philiptaron
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 425185
Commit: 9ab4929950d034b780afb037bb22548362afb96a


x86_64-linux

✅ 1 package built:
  • mpdris2-rs

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 26, 2025
@philiptaron philiptaron merged commit 2d5310a into NixOS:master Aug 26, 2025
45 of 49 checks passed
@acid-bong acid-bong deleted the init/mpdris2-rs branch August 26, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants