nixos/vector: add option to disable the configuration validation#425119
Merged
adamcstephens merged 1 commit intoNixOS:masterfrom Jul 22, 2025
Merged
nixos/vector: add option to disable the configuration validation#425119adamcstephens merged 1 commit intoNixOS:masterfrom
adamcstephens merged 1 commit intoNixOS:masterfrom
Conversation
Currently, during built time the configuration gets checked by vector. This can be a problem if [environment variables](https://vector.dev/docs/reference/environment_variables/) are interpolated into the configuration. In this case the validation can be disabled. This came up in trying to find a solution for [NixOS#377889](NixOS#377889).
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
adamcstephens
approved these changes
Jul 14, 2025
Contributor
adamcstephens
left a comment
adamcstephens
left a comment
There was a problem hiding this comment.
Seems reasonable to me. 👍
nixpkgs-ci
bot
added
12.approvals: 1
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-25.05
git worktree add -d .worktree/backport-425119-to-release-25.05 origin/release-25.05
cd .worktree/backport-425119-to-release-25.05
git switch --create backport-425119-to-release-25.05
git cherry-pick -x 6b4ce1ee231c408f467b3f3efd6c31533d483c44 |
Contributor
Author
|
@adamcstephens It seems like 25a40ea did not get backported, thus this backport failed. How can I help? |
Contributor
|
We can either cherry pick as described above, and resolve the conflict, or we can backport both. The latter seems fine to me, but either way it'll need to be done manually. |
13 tasks
Contributor
Author
|
Please excuse the delay, I have tried to do a manual backport in #428623. I hope I didn't miss something. |
mdaniels5757
added
8.has: port to stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, during built time the configuration gets checked by vector. This can be a problem if environment
variables are interpolated into the configuration. In this case the validation can be disabled. This came up in trying to find a solution for #377889.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.