Skip to content

Comments

python3Packages.wheel: update hash#424809

Closed
arianvp wants to merge 1 commit intoNixOS:masterfrom
arianvp:fix-wheel
Closed

python3Packages.wheel: update hash#424809
arianvp wants to merge 1 commit intoNixOS:masterfrom
arianvp:fix-wheel

Conversation

@arianvp
Copy link
Member

@arianvp arianvp commented Jul 13, 2025

b2fc3a5 seems to have forgotten to update the hash so this was still pointing to the old source code.

Seems to be genuine human error in this case but
it is what NixOS/rfcs#171 (comment) describes.

Luckily 0.45.1 doesn't have any known vulns

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

NixOS@b2fc3a5
seems to have forgotten to update the hash so this was still pointing
to the old source code.

Seems to be genuine human error in this case but
it is what NixOS/rfcs#171 (comment)
describes.

Luckily 0.45.1 doesn't have any known vulns
@arianvp
Copy link
Member Author

arianvp commented Jul 13, 2025

Oh. duplicate of #424195

@arianvp arianvp closed this Jul 13, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 6.topic: python Python is a high-level, general-purpose programming language. labels Jul 13, 2025
@nix-owners nix-owners bot requested a review from siriobalmelli July 13, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant