postgresqlPackages.postgis: fix cross-compilation#424800
Merged
onny merged 1 commit intoNixOS:masterfrom Jul 21, 2025
Merged
Conversation
ofborg
bot
added
the
6.topic: cross-compilation
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
wolfgangwalther
requested review from
MarcWeber,
autra,
imincik,
l0b0,
nh2,
nialov,
sikmir and
willcohen
sikmir
reviewed
Jul 17, 2025
autra
reviewed
Jul 18, 2025
Contributor
There was a problem hiding this comment.
Surprising: json_c doesn't work on RiscV?
Contributor
Author
There was a problem hiding this comment.
It is looking for the json libraries or header files but I couldn't get it to work. So this feature is missing but at least cross-compilation will work :)
Member
|
Contributor
Author
how did you build it? this should fix: nix build .#pkgsCross.riscv64.postgis |
Member
I mean the same error for other platforms |
sikmir
reviewed
Jul 18, 2025
sikmir
reviewed
Jul 18, 2025
sikmir
reviewed
Jul 18, 2025
sikmir
requested changes
Jul 18, 2025
Member
sikmir
left a comment
sikmir
left a comment
There was a problem hiding this comment.
Please update commit message to postgresqlPackages.postgis: fix cross-compilation.
Member
|
A bit refactored: diff --git i/pkgs/servers/sql/postgresql/ext/postgis.nix w/pkgs/servers/sql/postgresql/ext/postgis.nix
index 09c547075135..39b5329c993d 100644
--- i/pkgs/servers/sql/postgresql/ext/postgis.nix
+++ w/pkgs/servers/sql/postgresql/ext/postgis.nix
@@ -91,12 +91,19 @@ postgresqlBuildExtension (finalAttrs: {
./autogen.sh
'';
- configureFlags = [
- "--with-pgconfig=${postgresql.pg_config}/bin/pg_config"
- "--with-gdalconfig=${gdal}/bin/gdal-config"
- "--with-jsondir=${json_c.dev}"
- "--disable-extension-upgrades-install"
- ] ++ lib.optional withSfcgal "--with-sfcgal=${sfcgal}/bin/sfcgal-config";
+ configureFlags =
+ let
+ isCross = stdenv.hostPlatform != stdenv.buildPlatform;
+ in
+ [
+ (lib.enableFeature false "extension-upgrades-install")
+ (lib.withFeatureAs true "pgconfig" "${postgresql.pg_config}/bin/pg_config")
+ (lib.withFeatureAs true "gdalconfig" "${gdal}/bin/gdal-config")
+ (lib.withFeatureAs true "jsondir" (lib.getDev json_c))
+ (lib.withFeatureAs true "xml2config" (lib.getExe' (lib.getDev libxml2) "xml2-config"))
+ (lib.withFeatureAs withSfcgal "sfcgal" "${sfcgal}/bin/sfcgal-config")
+ (lib.withFeature (!isCross) "json") # configure: error: cannot check for file existence when cross compiling
+ ];
makeFlags = [
"PERL=${perl}/bin/perl" |
onny
changed the title
Contributor
Author
|
Thank you, added it! |
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
Contributor
There was a problem hiding this comment.
Comparing full platforms with == and != is a bit of an anti-pattern. Can we be any more specific? Why does cross fail in this case - is it because the build platform can't execute the host version of a dependency? Or what exactly is the reason?
Also see discussion in #380005.
Member
There was a problem hiding this comment.
Or what exactly is the reason?
configure: error: cannot check for file existence when cross compiling
I didn't dig deeper.
Contributor
There was a problem hiding this comment.
Seems like this error comes from the AC_CHECK_FILE macro in:
The macro is defined upstream here:
The cross_compiling thing is set here:
It looks like autoconf compares the triples it gets passed for that case.
Thus, I suggest this:
Suggested change
| isCross = stdenv.hostPlatform != stdenv.buildPlatform; | |
| isCross = stdenv.hostPlatform.config != stdenv.buildPlatform.config; |
Contributor
Author
There was a problem hiding this comment.
Added the changes and it's working. Thank you
sikmir
approved these changes
Jul 19, 2025
nixpkgs-ci
bot
added
12.approvals: 1
Contributor
Author
|
Thank you! |
Contributor
|
Successfully created backport PR for |
github-actions
bot
added
the
8.has: port to stable
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.