dwm{,-status}, dmenu{,-wayland}, st (+ forks): move to by-name, refactor
#424634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acid-bong
changed the title
by-name, refactorby-name, refactor
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
Also added `extraLibs`, like st has
It's no longer necessary + this allows for compiling with extraLibs, if config.mk was patched
acid-bong
force-pushed
the
refactor/suckless
branch
from
2cb66c8 to
6db8833
Compare
nixpkgs-ci
bot
added
10.rebuild-linux: 11-100
acid-bong
changed the title
by-name, refactorby-name, refactor
Also added support for `conf` and `extraLibs`
nix-owners
bot
requested review from
0david0mp,
Qusic,
globin,
pSub,
vyp and
wineee
acid-bong
commented
Jul 13, 2025
| @@ -50,25 +49,22 @@ stdenv.mkDerivation rec { | |||
| makeFlagsArray+=( | |||
| PREFIX="$out" | |||
| CC="$CC" | |||
| # default config.mk hardcodes dependent libraries and include paths | |||
| INCS="`$PKG_CONFIG --cflags fontconfig x11 xft xinerama`" | |||
| LIBS="`$PKG_CONFIG --libs fontconfig x11 xft xinerama`" | |||
Contributor
Author
Contributor
There was a problem hiding this comment.
Sounds fine to drop. Initial fix was a workaround for libxft missing dependency.
Contributor
Author
|
cc @neonfuz (wasn't pinged for some reason) |
Qusic
approved these changes
Jul 16, 2025
Member
Qusic
left a comment
Qusic
left a comment
There was a problem hiding this comment.
approving dmenu and st. thanks!
nixpkgs-ci
bot
added
12.approvals: 1
Member
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Personal checks
Refactor includes:
recwithfinalAttrswith lib;Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.