llvm_{38,39}: unconditionally set triples, not just w/musl#42463
Merged
dtzWill merged 2 commits intoNixOS:masterfrom Jun 25, 2018
Merged
llvm_{38,39}: unconditionally set triples, not just w/musl#42463dtzWill merged 2 commits intoNixOS:masterfrom
dtzWill merged 2 commits intoNixOS:masterfrom
Conversation
Follow-on to same changes made to other versions: See NixOS#42454, NixOS#42456.
Member
Author
|
Maybe start here since (I think?) these are lowest impact? I think Darwin builder might be able to give us feedback now... let's see! :) |
Member
Author
|
@GrahamcOfBorg build tests.cc-wrapper-libcxx-39 tests.cc-wrapper-clang-39 |
|
Success on aarch64-linux (full log) Attempted: tests.cc-wrapper-libcxx-39, tests.cc-wrapper-clang-39 Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: tests.cc-wrapper-libcxx-39, tests.cc-wrapper-clang-39 Partial log (click to expand)
|
Member
Author
|
Well didn't have fork failure, but timed out d'oh haha. |
|
Success on x86_64-linux (full log) Attempted: tests.cc-wrapper-libcxx-39, tests.cc-wrapper-clang-39 Partial log (click to expand)
|
Member
Author
|
This (and same changes to other versions) was requested to be made more general than musl, |
I should have "moved" the flags instead of "copying" them earlier :).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on to same changes made to other versions:
See #42454, #42456.
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)