Skip to content

python3Packages.tree-sitter-markdown: 0.5.0 -> 0.3.2#424541

Merged
GaetanLepage merged 3 commits intoNixOS:masterfrom
gepbird:tree-sitter-markdown-downgrade
Jul 13, 2025
Merged

python3Packages.tree-sitter-markdown: 0.5.0 -> 0.3.2#424541
GaetanLepage merged 3 commits intoNixOS:masterfrom
gepbird:tree-sitter-markdown-downgrade

Conversation

@gepbird
Copy link
Contributor

@gepbird gepbird commented Jul 12, 2025

Downgrade to the latest version on PyPI, as reverse dependencies also
pull from PyPI. The latest version on GitHub introduced breaking ABI
changes

See Textualize/textual#5868

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

gepbird added 3 commits July 12, 2025 10:56
Downgrade to the latest version on PyPI, as reverse dependencies also
pull from PyPI. The latest version on GitHub introduced breaking ABI
changes.
@gepbird gepbird requested a review from GaetanLepage July 12, 2025 08:59
@nixpkgs-ci nixpkgs-ci bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 12, 2025
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. I followed the conversation upstream. Downgrading seems to be the correct solution.

Just for the sake of posterity, this reverts of #411181

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jul 12, 2025
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 424541
Commit: ac954384ff0b60e6368632049f842694acd2a456


x86_64-linux

✅ 83 packages built:
  • bagels
  • bagels.dist
  • browsr
  • browsr.dist
  • dooit
  • dooit-extras
  • dooit-extras.dist
  • dooit.dist
  • frogmouth
  • frogmouth.dist
  • harlequin
  • harlequin.dist
  • isd
  • isd.dist
  • isponsorblocktv
  • isponsorblocktv.dist
  • memray
  • memray.dist
  • mutmut
  • mutmut.dist
  • oterm
  • oterm.dist
  • posting
  • posting.dist
  • python312Packages.manifestoo
  • python312Packages.manifestoo.dist
  • python312Packages.pytest-textual-snapshot
  • python312Packages.pytest-textual-snapshot.dist
  • python312Packages.textual
  • python312Packages.textual-autocomplete
  • python312Packages.textual-autocomplete.dist
  • python312Packages.textual-dev
  • python312Packages.textual-dev.dist
  • python312Packages.textual-fastdatatable
  • python312Packages.textual-fastdatatable.dist
  • python312Packages.textual-serve
  • python312Packages.textual-serve.dist
  • python312Packages.textual-slider
  • python312Packages.textual-slider.dist
  • python312Packages.textual-textarea
  • python312Packages.textual-textarea.dist
  • python312Packages.textual-universal-directorytree
  • python312Packages.textual-universal-directorytree.dist
  • python312Packages.textual.dist
  • python312Packages.tree-sitter-markdown
  • python312Packages.tree-sitter-markdown.dist
  • python313Packages.manifestoo
  • python313Packages.manifestoo.dist
  • python313Packages.pytest-textual-snapshot
  • python313Packages.pytest-textual-snapshot.dist
  • python313Packages.textual
  • python313Packages.textual-autocomplete
  • python313Packages.textual-autocomplete.dist
  • python313Packages.textual-dev
  • python313Packages.textual-dev.dist
  • python313Packages.textual-fastdatatable
  • python313Packages.textual-fastdatatable.dist
  • python313Packages.textual-serve
  • python313Packages.textual-serve.dist
  • python313Packages.textual-slider
  • python313Packages.textual-slider.dist
  • python313Packages.textual-textarea
  • python313Packages.textual-textarea.dist
  • python313Packages.textual-universal-directorytree
  • python313Packages.textual-universal-directorytree.dist
  • python313Packages.textual.dist
  • python313Packages.tree-sitter-markdown
  • python313Packages.tree-sitter-markdown.dist
  • rexi
  • rexi.dist
  • rich-cli
  • rich-cli.dist
  • smassh
  • smassh.dist
  • streamcontroller
  • tftui
  • tftui.dist
  • toolong
  • toolong.dist
  • upiano
  • upiano.dist
  • wsrepl
  • wsrepl.dist

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jul 13, 2025
@GaetanLepage GaetanLepage merged commit 659bede into NixOS:master Jul 13, 2025
28 of 32 checks passed
@gepbird gepbird deleted the tree-sitter-markdown-downgrade branch July 14, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants