patch-shebangs: fix binary data corrupt after patching#424278
Closed
DavHau wants to merge 1 commit intoNixOS:staging-nextfrom
Closed
patch-shebangs: fix binary data corrupt after patching#424278DavHau wants to merge 1 commit intoNixOS:staging-nextfrom
DavHau wants to merge 1 commit intoNixOS:staging-nextfrom
Conversation
This removes the recently introduced shell based implementation of `sponge` which wasn't capable of managing binary input. Now, a tmpFile under $TMPDIR is created manually and later deleted see: NixOS#414448 (comment)
Contributor
|
No can do, we'd discard the entire cycle. |
Member
Author
Sorry, I'm not 100% familiar with the release flow. Please instruct me how I can help to fix this. |
Contributor
|
It seems very unlikely that this is causing the Haskell failures, so it is probably just unnecessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #423137
This removes the recently introduced shell based implementation of
spongewhich wasn't capable of managing binary input.Now, a tmpFile under $TMPDIR is created manually and later deleted
see: #414448 (comment)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.