Skip to content

discord: fix krisp by using fhsEnv on linux #424232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
samschlegel wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

discord: fix krisp by using fhsEnv on linux #424232

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3945a71
discord: use fhsEnv on linux
samschlegel Jul 11, 2025
4d68add
some cleanup
samschlegel Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
290 changes: 173 additions & 117 deletions pkgs/applications/networking/instant-messengers/discord/linux.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,11 @@
meta,
binaryName,
desktopName,
autoPatchelfHook,
buildFHSEnv,
makeDesktopItem,
lib,
stdenv,
wrapGAppsHook3,
makeShellWrapper,
writeScript,
alsa-lib,
at-spi2-atk,
at-spi2-core,
Expand Down Expand Up @@ -44,18 +43,20 @@
libxcb,
libxshmfence,
libgbm,
libxkbcommon,
mesa,
nspr,
nss,
pango,
systemd,
libappindicator-gtk3,
libdbusmenu,
writeScript,
pipewire,
python3,
runCommand,
speechd-minimal,
wayland,
xorg,
branch,
withOpenASAR ? false,
openasar,
Expand Down Expand Up @@ -88,132 +89,158 @@ let
substituteAllInPlace $out/bin/disable-breaking-updates.py
chmod +x $out/bin/disable-breaking-updates.py
'';
in
stdenv.mkDerivation rec {
inherit
pname
version
src
meta
;

nativeBuildInputs = [
alsa-lib
autoPatchelfHook
cups
libdrm
libuuid
libXdamage
libX11
libXScrnSaver
libXtst
libxcb
libxshmfence
libgbm
nss
wrapGAppsHook3
makeShellWrapper
];
# Create the Discord application directory
discordDir = stdenv.mkDerivation {
name = "${pname}-${version}-dir";
inherit src;

# Disable automatic patching that could modify binaries
dontPatchELF = true;
dontStrip = true;
dontPatchShebangs = true;

dontBuild = true;
dontConfigure = true;

installPhase = ''
runHook preInstall

mkdir -p $out/opt/${binaryName}
mv * $out/opt/${binaryName}
cd $out/opt

dontWrapGApps = true;
# Apply modifications (do NOT chmod the binary - it breaks Krisp checksum validation)
${lib.optionalString withOpenASAR ''
cp -f ${openasar} resources/app.asar
''}
${lib.optionalString withVencord ''
mv resources/app.asar resources/_app.asar
mkdir resources/app.asar
echo '{"name":"discord","main":"index.js"}' > resources/app.asar/package.json
echo 'require("${vencord}/patcher.js")' > resources/app.asar/index.js
''}
${lib.optionalString withMoonlight ''
mv resources/app.asar resources/_app.asar
mkdir resources/app
echo '{"name":"discord","main":"injector.js","private": true}' > resources/app/package.json
echo 'require("${moonlight}/injector.js").inject(require("path").join(__dirname, "../_app.asar"));' > resources/app/injector.js
''}

runHook postInstall
'';
};

libPath = lib.makeLibraryPath (
[
libcxx
systemd
libpulseaudio
# FHS Environment with all necessary libraries
fhsEnv = buildFHSEnv {
name = "${pname}-fhs";

targetPkgs = pkgs: with pkgs; [
# Core system libraries
stdenv.cc.cc.lib
glibc

# Graphics and display
libglvnd
mesa
libdrm
libgbm
stdenv.cc.cc
alsa-lib
wayland

# X11 libraries
xorg.libX11
xorg.libXcomposite
xorg.libXcursor
xorg.libXdamage
xorg.libXext
xorg.libXfixes
xorg.libXi
xorg.libXrandr
xorg.libXrender
xorg.libXtst
xorg.libXScrnSaver
xorg.libxcb
xorg.libxshmfence

# GTK and desktop integration
gtk3
glib
cairo
pango
gdk-pixbuf
atk
at-spi2-atk
at-spi2-core
cairo
cups
libappindicator-gtk3
libdbusmenu

# Audio
alsa-lib
libpulseaudio
pipewire

# Other system libraries
dbus
expat
systemd
fontconfig
freetype
gdk-pixbuf
glib
gtk3
libglvnd
libnotify
libX11
libXcomposite
expat
libuuid
libXcursor
libXdamage
libXext
libXfixes
libXi
libXrandr
libXrender
libXtst
cups
nspr
libxcb
pango
pipewire
libXScrnSaver
libappindicator-gtk3
libdbusmenu
wayland
]
++ lib.optional withTTS speechd-minimal
);

installPhase = ''
runHook preInstall

mkdir -p $out/{bin,opt/${binaryName},share/pixmaps,share/icons/hicolor/256x256/apps}
mv * $out/opt/${binaryName}

chmod +x $out/opt/${binaryName}/${binaryName}
patchelf --set-interpreter ${stdenv.cc.bintools.dynamicLinker} \
$out/opt/${binaryName}/${binaryName}

wrapProgramShell $out/opt/${binaryName}/${binaryName} \
"''${gappsWrapperArgs[@]}" \
--add-flags "\''${NIXOS_OZONE_WL:+\''${WAYLAND_DISPLAY:+--ozone-platform=wayland --enable-features=WaylandWindowDecorations --enable-wayland-ime=true}}" \
${lib.strings.optionalString withTTS ''
--run 'if [[ "''${NIXOS_SPEECH:-default}" != "False" ]]; then NIXOS_SPEECH=True; else unset NIXOS_SPEECH; fi' \
--add-flags "\''${NIXOS_SPEECH:+--enable-speech-dispatcher}" \
''} \
${lib.strings.optionalString enableAutoscroll "--add-flags \"--enable-blink-features=MiddleClickAutoscroll\""} \
--prefix XDG_DATA_DIRS : "${gtk3}/share/gsettings-schemas/${gtk3.name}/" \
--prefix LD_LIBRARY_PATH : ${libPath}:$out/opt/${binaryName} \
${lib.strings.optionalString disableUpdates "--run ${lib.getExe disableBreakingUpdates}"} \
--add-flags ${lib.escapeShellArg commandLineArgs}

ln -s $out/opt/${binaryName}/${binaryName} $out/bin/
# Without || true the install would fail on case-insensitive filesystems
ln -s $out/opt/${binaryName}/${binaryName} $out/bin/${lib.strings.toLower binaryName} || true

ln -s $out/opt/${binaryName}/discord.png $out/share/pixmaps/${pname}.png
ln -s $out/opt/${binaryName}/discord.png $out/share/icons/hicolor/256x256/apps/${pname}.png

ln -s "$desktopItem/share/applications" $out/share/

runHook postInstall
'';

postInstall =
lib.strings.optionalString withOpenASAR ''
cp -f ${openasar} $out/opt/${binaryName}/resources/app.asar
''
+ lib.strings.optionalString withVencord ''
mv $out/opt/${binaryName}/resources/app.asar $out/opt/${binaryName}/resources/_app.asar
mkdir $out/opt/${binaryName}/resources/app.asar
echo '{"name":"discord","main":"index.js"}' > $out/opt/${binaryName}/resources/app.asar/package.json
echo 'require("${vencord}/patcher.js")' > $out/opt/${binaryName}/resources/app.asar/index.js
''
+ lib.strings.optionalString withMoonlight ''
mv $out/opt/${binaryName}/resources/app.asar $out/opt/${binaryName}/resources/_app.asar
mkdir $out/opt/${binaryName}/resources/app
echo '{"name":"discord","main":"injector.js","private": true}' > $out/opt/${binaryName}/resources/app/package.json
echo 'require("${moonlight}/injector.js").inject(require("path").join(__dirname, "../_app.asar"));' > $out/opt/${binaryName}/resources/app/injector.js
nss
libnotify
libcxx
libxkbcommon
] ++ lib.optional withTTS pkgs.speechd-minimal;

multiPkgs = pkgs: [
# Additional 32-bit libraries if needed
pkgs.alsa-lib
pkgs.libpulseaudio
];

# Set up the runtime environment
runScript = writeScript "${pname}-wrapper" ''
#!/bin/bash

# Run the disable updates script if enabled
${lib.optionalString disableUpdates ''
${lib.getExe disableBreakingUpdates}
''}

# Set up environment variables
export XDG_DATA_DIRS="${gtk3}/share/gsettings-schemas/${gtk3.name}/:$XDG_DATA_DIRS"

# Handle Wayland
if [[ -n "$NIXOS_OZONE_WL" && -n "$WAYLAND_DISPLAY" ]]; then
WAYLAND_FLAGS="--ozone-platform=wayland --enable-features=WaylandWindowDecorations --enable-wayland-ime=true"
fi

# Handle TTS
${lib.optionalString withTTS ''
if [[ "''${NIXOS_SPEECH:-default}" != "False" ]]; then
export NIXOS_SPEECH=True
TTS_FLAGS="--enable-speech-dispatcher"
fi
''}

# Handle autoscroll
${lib.optionalString enableAutoscroll ''
AUTOSCROLL_FLAGS="--enable-blink-features=MiddleClickAutoscroll"
''}

# Execute Discord
exec ${discordDir}/opt/${binaryName}/${binaryName} \
--no-sandbox \
--disable-gpu-sandbox \
Copy link
Author

@samschlegel samschlegel Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this definitely seems non-ideal lol. Hopefully there's some other way around the zygote/GPU launch issues?

Copy link
Author

@samschlegel samschlegel Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this seems to be common between other electron apps, and the only other solution I've found seems to be not putting it in a sandbox, or using something like the Flathub version does with https://github.com/refi64/zypak to wrap Chromium in a way that it works in a nested sandbox. I don't see any specific usages of this tool in nixpkgs but perhaps there's another option.

At this point though this works well enough for my use cases so I won't personally be looking into other paths

Copy link
Member

@nezia1 nezia1 Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I tried running the binary directly from your PR result/bin/Discord, removed those two flags and it seemed to run just fine? I'm not sure if they changed anything but your PR works for me. When was the application crashing for you?

Copy link
Author

@samschlegel samschlegel Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know there was an electron upgrade recently so perhaps that fixed things? I've actually moved back to a fedora base + home-manager so if you want to make that change then go for it

$WAYLAND_FLAGS \
$TTS_FLAGS \
$AUTOSCROLL_FLAGS \
${lib.escapeShellArg commandLineArgs} \
"$@"
'';
};

desktopItem = makeDesktopItem {
name = pname;
Expand All @@ -228,7 +255,36 @@ stdenv.mkDerivation rec {
mimeTypes = [ "x-scheme-handler/discord" ];
startupWMClass = "discord";
};

in
stdenv.mkDerivation {
inherit pname version meta;

dontUnpack = true;
dontBuild = true;
dontConfigure = true;

installPhase = ''
runHook preInstall

mkdir -p $out/bin
mkdir -p $out/share/applications
mkdir -p $out/share/pixmaps
mkdir -p $out/share/icons/hicolor/256x256/apps

# Install the FHS wrapper
ln -s ${fhsEnv}/bin/${pname}-fhs $out/bin/${binaryName}
ln -s ${fhsEnv}/bin/${pname}-fhs $out/bin/${lib.strings.toLower binaryName}

# Install icons
ln -s ${discordDir}/opt/${binaryName}/discord.png $out/share/pixmaps/${pname}.png
ln -s ${discordDir}/opt/${binaryName}/discord.png $out/share/icons/hicolor/256x256/apps/${pname}.png

# Install desktop file
ln -s ${desktopItem}/share/applications/${pname}.desktop $out/share/applications/

runHook postInstall
'';

passthru = {
# make it possible to run disableBreakingUpdates standalone
inherit disableBreakingUpdates;
Expand Down
Loading