Skip to content

androidndk: cleanups#42397

Merged
Ericson2314 merged 4 commits intoNixOS:masterfrom
obsidiansystems:more-android-fixes
Jun 22, 2018
Merged

androidndk: cleanups#42397
Ericson2314 merged 4 commits intoNixOS:masterfrom
obsidiansystems:more-android-fixes

Conversation

@matthewbauer
Copy link
Member

Motivation for this change

These are some more android fixups. Hopefully these are all good changes.

/cc @bkchr

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@matthewbauer matthewbauer requested a review from Ericson2314 June 22, 2018 20:33
This is a free version and preferred to 7zip.
@matthewbauer matthewbauer changed the title androidndk: fixup androidndk: cleanups Jun 22, 2018
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 22, 2018
Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually it would be nice to use multiple outputs to get around the size limits, but @edolstra says hydra/nix sums it, so this is good for now.

@Ericson2314 Ericson2314 merged commit bbef861 into NixOS:master Jun 22, 2018
@Ericson2314 Ericson2314 deleted the more-android-fixes branch June 22, 2018 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants