Skip to content

Comments

qt6.qtwebengine: fix build#423843

Merged
K900 merged 1 commit intoNixOS:staging-nextfrom
Prince213:push-ywqmwnkxqvwu
Jul 10, 2025
Merged

qt6.qtwebengine: fix build#423843
K900 merged 1 commit intoNixOS:staging-nextfrom
Prince213:push-ywqmwnkxqvwu

Conversation

@Prince213
Copy link
Member

@Prince213 Prince213 commented Jul 9, 2025 •
edited
Loading

This backports a upstream patch: https://chromium-review.googlesource.com/c/chromium/src/+/6445471

Related hydra jobs:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jul 9, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Jul 9, 2025
@Prince213 Prince213 force-pushed the push-ywqmwnkxqvwu branch 3 times, most recently from 23be551 to 4722529 Compare July 10, 2025 04:39
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Jul 10, 2025
@Prince213 Prince213 force-pushed the push-ywqmwnkxqvwu branch 2 times, most recently from 1efb458 to 29839dc Compare July 10, 2025 11:26
@Prince213 Prince213 changed the base branch from master to staging-next July 10, 2025 11:26
@nixpkgs-ci nixpkgs-ci bot closed this Jul 10, 2025
@nixpkgs-ci nixpkgs-ci bot reopened this Jul 10, 2025
@Prince213 Prince213 marked this pull request as ready for review July 10, 2025 11:30
@Prince213 Prince213 changed the title qt6.qtwebengine: fix build on darwin qt6.qtwebengine: fix build Jul 10, 2025
@K900
Copy link
Contributor

K900 commented Jul 10, 2025

Can we scope the patch to Darwin for now?

@Prince213
Copy link
Member Author

Prince213 commented Jul 10, 2025

Can we scope the patch to Darwin for now?

We can limit the scope to Clang, I think GCC is okay with this.

@Prince213 Prince213 force-pushed the push-ywqmwnkxqvwu branch from 29839dc to afd4014 Compare July 10, 2025 11:39
@Prince213 Prince213 force-pushed the push-ywqmwnkxqvwu branch from afd4014 to 7f96522 Compare July 10, 2025 11:41
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 10, 2025
@K900
Copy link
Contributor

K900 commented Jul 10, 2025

Cool, I'll merge this, and can you PR removing the conditional on staging-not-next?

@K900 K900 merged commit 1580a20 into NixOS:staging-next Jul 10, 2025
20 of 24 checks passed
@Prince213
Copy link
Member Author

Prince213 commented Jul 10, 2025

Cool, I'll merge this, and can you PR removing the conditional on staging-not-next?

Sure, will do.

This was referenced Jul 10, 2025
Merged
Merged
Merged
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jul 12, 2025

Successfully created backport PR for release-25.05:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Jul 12, 2025
Merged
1 task
@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jul 12, 2025
@Prince213 Prince213 mentioned this pull request Sep 12, 2025
Closed
@Prince213 Prince213 mentioned this pull request Oct 19, 2025
Merged
13 tasks
@infinisil infinisil mentioned this pull request Nov 5, 2025
Merged
@Prince213 Prince213 deleted the push-ywqmwnkxqvwu branch November 25, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel

@K900 K900 Awaiting requested review from K900

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@NickCao NickCao Awaiting requested review from NickCao

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Prince213 @K900 @vcunat