rstudio: fix build to use compatible boost version#42383
Merged
orivej-nixos merged 1 commit intoNixOS:masterfrom Jul 5, 2018
Merged
rstudio: fix build to use compatible boost version#42383orivej-nixos merged 1 commit intoNixOS:masterfrom
orivej-nixos merged 1 commit intoNixOS:masterfrom
Conversation
Contributor
|
@GrahamcOfBorg build rstudio |
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: rstudio Partial log (click to expand)
|
|
Failure on x86_64-linux (full log) Attempted: rstudio Partial log (click to expand)
|
Contributor
Build error is unrelated to this PR, see https://hydra.nixos.org/build/76464044, and should be fixed first. |
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: rstudio Partial log (click to expand)
|
3a83195 to
cc29280
Compare
orivej
reviewed
Jul 5, 2018
| rstudio = libsForQt5.callPackage ../applications/editors/rstudio { }; | ||
| rstudio = libsForQt5.callPackage ../applications/editors/rstudio { | ||
| boost = boost166; | ||
| }; |
Contributor
There was a problem hiding this comment.
Versions should be overridden in all-packages.nix, like this. It makes it easier to spot and remove outdated overrides.
Contributor
Author
There was a problem hiding this comment.
Thanks, much clearer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This fixes compile errors, currently hidden until a compatible qt5 version (5.11.1) is used (which is not the case in master yet: #42351 ).
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)