Skip to content

rstudio: fix build to use compatible boost version#42383

Merged
orivej-nixos merged 1 commit intoNixOS:masterfrom
averelld:rstudio-build-fixes
Jul 5, 2018
Merged

rstudio: fix build to use compatible boost version#42383
orivej-nixos merged 1 commit intoNixOS:masterfrom
averelld:rstudio-build-fixes

Conversation

@averelld
Copy link
Contributor

Motivation for this change

This fixes compile errors, currently hidden until a compatible qt5 version (5.11.1) is used (which is not the case in master yet: #42351 ).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 22, 2018
@xeji
Copy link
Contributor

xeji commented Jun 24, 2018

@GrahamcOfBorg build rstudio

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: rstudio

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: rstudio

Partial log (click to expand)


CMake Error at src/cpp/desktop/CMakeLists.txt:328 (qt5_use_modules):
  Unknown CMake command "qt5_use_modules".


-- Configuring incomplete, errors occurred!
See also "/build/source/build/CMakeFiles/CMakeOutput.log".
See also "/build/source/build/CMakeFiles/CMakeError.log".
builder for '/nix/store/vl95nlnlcwb8q813i4gcci87g7xyig52-RStudio-1.1.442.drv' failed with exit code 1
error: build of '/nix/store/vl95nlnlcwb8q813i4gcci87g7xyig52-RStudio-1.1.442.drv' failed

@xeji
Copy link
Contributor

xeji commented Jun 24, 2018

CMake Error at src/cpp/desktop/CMakeLists.txt:328 (qt5_use_modules):
  Unknown CMake command "qt5_use_modules".

Build error is unrelated to this PR, see https://hydra.nixos.org/build/76464044, and should be fixed first.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: rstudio

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@orivej-nixos orivej-nixos force-pushed the rstudio-build-fixes branch from 3a83195 to cc29280 Compare July 5, 2018 05:16
Copy link
Contributor

@orivej orivej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

rstudio = libsForQt5.callPackage ../applications/editors/rstudio { };
rstudio = libsForQt5.callPackage ../applications/editors/rstudio {
boost = boost166;
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Versions should be overridden in all-packages.nix, like this. It makes it easier to spot and remove outdated overrides.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, much clearer.

@orivej-nixos orivej-nixos merged commit 11c61ea into NixOS:master Jul 5, 2018
@averelld averelld deleted the rstudio-build-fixes branch July 5, 2018 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants