Upgraded termite to v8, and its dependency vte to v0.38.0

[k0ral]

No description provided.

[lucabrunox]

Where is the NEWS for vte 0.38? Does it break any specific behavior compared to 0.36?

[k0ral]

The NEWS for 0.38.0 is not published yet, as far as I know.
All I know is that the API changed between 0.36 and 0.37.

[lucabrunox]

Upstream bug, asking for NEWS: https://bugzilla.gnome.org/show_bug.cgi?id=739223

[lucabrunox]

Seems like 0.38 is backwards incompatible: https://bugzilla.gnome.org/show_bug.cgi?id=739223

[k0ral]

At first sight, I can't find any package in nixpkgs that currently depends on gnome3_12.vte, so breaking the API isn't a big deal, is it ?

[lucabrunox]

@k0ral some packages in gnome3_12 namespace probably. Also vte 0.38 is just not gnome 3.12, but gnome 3.14. So please, just add a vte_038 somewhere if you need it, until gnome3_14 is added.

[vcunat]

I see about five packages depending on gnome3.vte (counted direct references from all-packages.nix).

So now we will be using three different vte versions. Since they are quite used outside of gnome as well, maybe it would be better to keep them separate from gnomes, all three branches next to each other.

[lucabrunox]

See 383075e for an example of breakage

[k0ral]

@vcunat: gnome3 points to gnome3_10; as I only intend to upgrade vte within gnome3_12, anything that depends on gnome3.vte is unaffected.

[k0ral]

Updated pull request, please let me know if I forgot something.

[lucabrunox]

What's this change?

[k0ral]

I've removed unnecessary dependencies. They were mistakenly added in k0ral@2a56f3d . Only vte-0.38.0 requires vala and libxml2

[lucabrunox]

Sorry for being annoying, however can you please squash the commits and force push?

[k0ral]

The commit k0ral@2a56f3d is already merged in master (it comes from an earlier pull request), I can't squash it :) .

[lucabrunox]

Git master has vala and libxml2, you are removing it. This PR is in fact unmergeable, you are probably tracking an old master.

[k0ral]

Indeed, this PR has been opened for some time now, it's based on an old master.
I'll rebase and force push it again.

[k0ral]

Rebased on current master. PR is now mergeable.

[lucabrunox]

Ok thanks.

[vcunat]

Looks like just a missing patchShebangs, e.g. in preConfigure.

[vcunat]

@k0ral: please, fill a machine-readable e-mail into your git author settings, preferably the one you have registered with github. It seems nice when one can determine the github author of commits easily. (This is just for future commits.)

[k0ral]

@vcunat: ok for the e-mail.

[jagajaga]

Please make version as version=NUMBER because otherwise nix's system of version changing detection fails. I mean pkg name should be smth like termite-8.

[jagajaga]

@k0ral and, btw, it works for you? I can't enter insert mode.

[k0ral]

v9 is out, I'll upgrade the derivation while taking into account your remark on the version.
I'll tell you if it works when it's done building.

[jagajaga]

Thank you.

On 5 November 2014 01:25:12 k0ral notifications@github.com wrote:

v9 is out, I'll upgrade the derivation while taking into account your
remark on the version.
I'll tell you if it works when it's done building.

---

Reply to this email directly or view it on GitHub:
#4237 (comment)

[k0ral]

@jagajaga v9 (cf #4837) works fine for me, including insert mode.