Skip to content

nixos/thefuck: move init scripts to programs.*.interactiveShellInit#42356

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
Ma27:fix-thefuck-module
Jun 22, 2018
Merged

nixos/thefuck: move init scripts to programs.*.interactiveShellInit#42356
Mic92 merged 1 commit intoNixOS:masterfrom
Ma27:fix-thefuck-module

Conversation

@Ma27
Copy link
Member

@Ma27 Ma27 commented Jun 21, 2018

Motivation for this change

fuck should only be used for interactive sessions, but nothing more
(so init files like /etc/zshenv become even more lightweight).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

`fuck` should only be used for interactive sessions, but nothing more
(so init files like `/etc/zshenv` become even more lightweight).
@Ma27
Copy link
Member Author

Ma27 commented Jun 21, 2018

checked inside a VM with the following configuration:

{
  test = {
    users.extraUsers.vm = {
      initialPassword = "vm";
      extraGroups = [ "wheel" ];
    };

    programs = {
      fish.enable = true;
      zsh.enable = true;
      thefuck.enable = true;
    };
  };
}

@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 21, 2018
@Mic92 Mic92 merged commit 85b1312 into NixOS:master Jun 22, 2018
@Ma27 Ma27 deleted the fix-thefuck-module branch June 22, 2018 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants