python3Packages.git-annex-adapter: fix build#42345
Merged
FRidh merged 1 commit intoNixOS:masterfrom Jun 23, 2018
Merged
Conversation
FRidh
reviewed
Jun 22, 2018
The exception message is broken becuase of some uppercase vs. lowercase issues that have been patched accordingly. Additionally use `fetchpatch` rather than `fetchurl` to apply patches into the build.
a491de8 to
47558d9
Compare
Member
Author
|
@FRidh dammit, thanks :D |
Member
|
@GrahamcOfBorg build python3Packages.git-annex-adapter |
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: python3Packages.git-annex-adapter Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: python3Packages.git-annex-adapter Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: python3Packages.git-annex-adapter Partial log (click to expand)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The exception message is broken becuase of some uppercase vs. lowercase
issues that have been patched accordingly.
Additionally use
fetchpatchrather thanfetchurlto apply patchesinto the build.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)