nixos/testing: Add test attribute to please discoverTests#423272
nixos/testing: Add test attribute to please discoverTests#423272wolfgangwalther merged 2 commits intoNixOS:masterfrom
Conversation
Exactly equivalent
1792768 to
474e1c8
Compare
MattSturgeon
left a comment
There was a problem hiding this comment.
Diff looks good. I've not tested if this resolved the reported issue.
wolfgangwalther
left a comment
There was a problem hiding this comment.
Diff LGTM; but I can't tell whether it's enough, or whether there are any other cases that will still throw similarly.
474e1c8 to
33d3bf5
Compare
33d3bf5 to
0e32661
Compare
|
@trofi can you run your script on this branch again and see whether there are any other regressions from that PR? |
No regressions. |
discoverTests again.|
@trofi I saw your approval was gray not green, indicating you're not a committer. My journey ultimately lead me to NixOS/nixpkgs-committers#60 (comment) - and I wanted to ask whether your situation has maybe changed today? Your activity on GitHub and Nixpkgs seems to indiciate - to me - that maybe, hopefully, that could be the case. |
|
No, no improvement. It's actually the other way around: I had to cut down a few more |
discoverTestsis bankrupt in tech debt, so we work around it until Tracking: migrate NixOShandleTest->runTest#386873 is done.This is in response to NixOS test framework: add overriding methods #421480 (comment)
This makes it a happy lambda again:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.