Skip to content

tasknc: fix#42309

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
infinisil:fix/tasknc
Jun 20, 2018
Merged

tasknc: fix#42309
Mic92 merged 1 commit intoNixOS:masterfrom
infinisil:fix/tasknc

Conversation

@infinisil
Copy link
Member

Motivation for this change

Was broken on master since #34477 which updated ncurses to 6.1. Switching to version 5 makes it work again.

Ping @dtzWill

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Jun 20, 2018

@GrahamcOfBorg build tasknc

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tasknc

Partial log (click to expand)

install -D -m644 config /nix/store/igrp3mr59slxnpqrw0xs0lg62y0zn1a0-tasknc-2017-05-15/share/tasknc/config
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/igrp3mr59slxnpqrw0xs0lg62y0zn1a0-tasknc-2017-05-15
shrinking /nix/store/igrp3mr59slxnpqrw0xs0lg62y0zn1a0-tasknc-2017-05-15/bin/.tasknc-wrapped
gzipping man pages under /nix/store/igrp3mr59slxnpqrw0xs0lg62y0zn1a0-tasknc-2017-05-15/share/man/
strip is /nix/store/min150lkigznaayzpwvf8d4jdl1dqvx6-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/igrp3mr59slxnpqrw0xs0lg62y0zn1a0-tasknc-2017-05-15/bin
patching script interpreter paths in /nix/store/igrp3mr59slxnpqrw0xs0lg62y0zn1a0-tasknc-2017-05-15
checking for references to /build in /nix/store/igrp3mr59slxnpqrw0xs0lg62y0zn1a0-tasknc-2017-05-15...
/nix/store/igrp3mr59slxnpqrw0xs0lg62y0zn1a0-tasknc-2017-05-15

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tasknc

Partial log (click to expand)

install -D -m644 config /nix/store/nprfb4klwpmhdbsb86p5zvarc34vim8z-tasknc-2017-05-15/share/tasknc/config
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/nprfb4klwpmhdbsb86p5zvarc34vim8z-tasknc-2017-05-15
shrinking /nix/store/nprfb4klwpmhdbsb86p5zvarc34vim8z-tasknc-2017-05-15/bin/.tasknc-wrapped
gzipping man pages under /nix/store/nprfb4klwpmhdbsb86p5zvarc34vim8z-tasknc-2017-05-15/share/man/
strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/nprfb4klwpmhdbsb86p5zvarc34vim8z-tasknc-2017-05-15/bin
patching script interpreter paths in /nix/store/nprfb4klwpmhdbsb86p5zvarc34vim8z-tasknc-2017-05-15
checking for references to /build in /nix/store/nprfb4klwpmhdbsb86p5zvarc34vim8z-tasknc-2017-05-15...
/nix/store/nprfb4klwpmhdbsb86p5zvarc34vim8z-tasknc-2017-05-15

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: tasknc

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@Mic92 Mic92 merged commit 04917b2 into NixOS:master Jun 20, 2018
infinisil added a commit to infinisil/system that referenced this pull request Jun 20, 2018
infinisil added a commit to infinisil/system that referenced this pull request Jun 20, 2018
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 20, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tasknc

Partial log (click to expand)

/nix/store/igrp3mr59slxnpqrw0xs0lg62y0zn1a0-tasknc-2017-05-15

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tasknc

Partial log (click to expand)

/nix/store/nprfb4klwpmhdbsb86p5zvarc34vim8z-tasknc-2017-05-15

@dtzWill
Copy link
Member

dtzWill commented Jun 23, 2018

Thank you! Sorry for missing the ping, not sure how that happened. Glad you sorted it out.

@infinisil infinisil deleted the fix/tasknc branch June 30, 2018 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants