v4l-utils: fix build for musl#422973
Merged
alyssais merged 1 commit intoNixOS:stagingfrom Jul 7, 2025
Merged
Conversation
21 tasks
ofborg
bot
added
the
2.status: merge conflict
Member
Author
|
(Note that on current staging a dependency fails to build, which I'm working on with upstream. I tested this on top of alyssais@9e25ab5.) |
ofborg
bot
removed
the
2.status: merge conflict
Fixes: 9e25ab5 ("v4l-utils: 1.24.1 -> 1.30.1")
nixpkgs-ci
bot
added
10.rebuild-linux: 501+
7c6f434c
approved these changes
Jul 7, 2025
Member
7c6f434c
left a comment
7c6f434c
left a comment
There was a problem hiding this comment.
I have read the code and I have looked up the context and all this looks good!
nixpkgs-ci
bot
added
the
12.approvals: 1
flokli
approved these changes
Jul 7, 2025
nixpkgs-ci
bot
added
12.approvals: 2
Yarny0
approved these changes
Jul 7, 2025
Contributor
Yarny0
left a comment
Yarny0
left a comment
There was a problem hiding this comment.
Sorry for breaking the musl build. muls is not really on my radar.
I tested this, after cherry-picking the commit onto https://github.com/NixOS/nixpkgs/tree/e13c3c3628760473f7cf72d87e13e7f3c5a6f7e9 :
pkgsMuls.v4l-utilsbuilds fine.dvbv5-zap(from that musl build) is able to tune and record a DVB-S2 channel with my DVB hardware.
While I can't test much more, this looks good and reasonable to me.
nixpkgs-ci
bot
added
12.approvals: 3+
Member
Author
|
No worries! Without CI I don't really expect people to notice. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.