Skip to content

fcitx-qt5: fix build with Qt 5.11#42297

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
mnacamura:fcitx-qt5
Jun 20, 2018
Merged

fcitx-qt5: fix build with Qt 5.11#42297
Mic92 merged 1 commit intoNixOS:masterfrom
mnacamura:fcitx-qt5

Conversation

@mnacamura
Copy link
Contributor

Motivation for this change

See fcitx/fcitx-qt5#34

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 20, 2018
@Mic92
Copy link
Member

Mic92 commented Jun 20, 2018

Can you apply a patch with fetchpatch instead? fcitx/fcitx-qt5@af033e3

Then we know when to drop the patch on updates.

@mnacamura
Copy link
Contributor Author

Changed it accordingly.

@Mic92 Mic92 merged commit d91c701 into NixOS:master Jun 20, 2018
@Mic92
Copy link
Member

Mic92 commented Jun 20, 2018

Thanks!

@mnacamura mnacamura deleted the fcitx-qt5 branch June 21, 2018 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants