freecad: enable ifc unconditionally#422675
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
LordGrimmauld
force-pushed
the
freecad-ifc
branch
from
fa28145 to
1956444
Compare
nixpkgs-ci
bot
added
the
9.needs: reviewer
pkgs/by-name/fr/freecad/package.nix
Outdated
There was a problem hiding this comment.
Nit: maybe keep the list sorted.
There was a problem hiding this comment.
Seriously? Not even whitespace changes, literally just orderin? Make a documentation suggestion if you actually care about these things, don't nit on random trivial PRs!
Anyways, fixed...
There was a problem hiding this comment.
Sorry if this comment wasn't clear. I intentionally made a comment (and not a request for change) and prefixed my comment with "Nit". Indeed, such comments should not be blocking and you are free to ignore it as you wish.
Maybe I should have made it even more clear. Sorry once again for the misunderstanding.
There was a problem hiding this comment.
Sure, it was marked nit, and not marked as requested change. Personally i find it weird if all someone reviews is trivial nits and nothing substantial: I am happy to hear nits if i have to touch changes anyways, but if nits are the only complaint they quickly feel overly pedantic. But fair enough, you did say nit, lets not get stuck on semantics here. Thanks for taking the time to review this change set, you could have ignored it completely too tbf.
There was a problem hiding this comment.
Yes, I wanted to follow-up with a merge, but the PR slipped from my sight. Again sorry for the unusual friction.
nixpkgs-ci
bot
removed
the
9.needs: reviewer
closes NixOS#370121 follow-up to NixOS#330190 The BIM workspace depends on ifc, there is little reason why it should be conditional to a flag that causes a from-source rebuild. It should just be always enabled.
LordGrimmauld
force-pushed
the
freecad-ifc
branch
from
1956444 to
f772e38
Compare
|
GaetanLepage
left a comment
GaetanLepage
left a comment
There was a problem hiding this comment.
Thanks @LordGrimmauld !
2 participants
closes #370121
follow-up to #330190
The BIM workspace depends on ifc, there is little reason why it should be conditional to a flag that causes a from-source rebuild. It should just be always enabled.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.