Skip to content

po4a: disable tests#422319

Merged
K900 merged 1 commit intoNixOS:staging-nextfrom
trofi:po4a-no-tests
Jul 5, 2025
Merged

po4a: disable tests#422319
K900 merged 1 commit intoNixOS:staging-nextfrom
trofi:po4a-no-tests

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Jul 4, 2025

After a gettext-0.25 update the tests started failing for CR/LF files: mquinson/po4a#580

Let's disable the on all platforms.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

After a `gettext-0.25` update the tests started failing for CR/LF files:
mquinson/po4a#580

Let's disable the on all platforms.
@trofi trofi mentioned this pull request Jul 4, 2025
13 tasks
@nix-owners nix-owners bot requested review from marcusramberg, stigtsp and zakame July 4, 2025 07:19
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jul 4, 2025
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 4, 2025
@K900 K900 changed the base branch from staging to staging-next July 5, 2025 13:10
@K900 K900 merged commit 5fff84c into NixOS:staging-next Jul 5, 2025
30 of 34 checks passed
@trofi trofi deleted the po4a-no-tests branch July 5, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants