php85: init at 8.5.1 #422308
Open
php85: init at 8.5.1 #422308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixpkgs-ci
bot
added
6.topic: php
drupol
force-pushed
the
push-yzozlvtlorrx
branch
3 times, most recently
from
c36c14e to
5fc3895
Compare
nixpkgs-ci
bot
added
10.rebuild-linux: 501+
drupol
force-pushed
the
push-yzozlvtlorrx
branch
2 times, most recently
from
a713c8e to
10b8170
Compare
drupol
force-pushed
the
push-yzozlvtlorrx
branch
2 times, most recently
from
b1298fa to
356455d
Compare
Contributor
|
Before this gets merged we should review external (pecl) extensions most likely they'll fail. I'll try to build all of them tomorrow. I tried to nix-review on this PR but I run out of memory (32gb). I'll reduce number of builder and give it another go. |
Contributor
|
nixpkgs-ci
bot
removed
the
10.rebuild-darwin: 501+
nixpkgs-ci
bot
added
10.rebuild-linux: 501+
Contributor
|
Uri extension doesn't seem to work https://www.php.net/releases/8.5/en.php#new-uri-extension It depends on the lexbor lib too. |
Contributor
|
adding fixes it: |
drupol
force-pushed
the
push-yzozlvtlorrx
branch
from
a29ce80 to
b0b1ae7
Compare
Member
|
Can you elaborate why this is needed, then? |
Contributor
|
uri should be in optionals 8.5+ the same as lexbor as it was introduced in php 8.5 |
Contributor
Author
I'll be investigating this further tomorrow,went to bed already. I'll let you know more asap. |
Contributor
|
Overall lexbor and uri extensions are more or less shared libs. They don't have .so files and aren't toggle by a user. They're always enabled. |
Member
This doesn't answer my question though. How is this package serving any value? This is literally an empty directory and nothing else. Assuming this actually made a difference for you, we should carefully investigate what happened because we're clearly not understanding what's going on currently. |
Contributor
|
I think dev part makes it work: Maybe mkdir and cp should in the same condition |
Member
|
Ah right, it's the headers making the difference. IMHO we're holding this wrong then: like, why have a "package" for something that's not supposed to be its own package? Sure, header-only libraries are a thing, but If we need it anyways by default, what's the reason for not making this part of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.