Skip to content

Comments

opencv.passthru.tests.opencv4-tests: refactor and fix CUDA tests#422208

Merged
philiptaron merged 1 commit intoNixOS:masterfrom
ConnorBaker:fix/opencv-cuda-tests
Jul 16, 2025
Merged

opencv.passthru.tests.opencv4-tests: refactor and fix CUDA tests#422208
philiptaron merged 1 commit intoNixOS:masterfrom
ConnorBaker:fix/opencv-cuda-tests

Conversation

@ConnorBaker
Copy link
Contributor

@ConnorBaker ConnorBaker commented Jul 3, 2025 •
edited
Loading

Refactors the OpenCV tests to reduce the amount of templating necessary through __structuredAttrs.

Enables running tests with CUDA support on NixOS.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@ConnorBaker
opencv.passthru.tests.opencv4-tests: refactor and fix CUDA tests
f4fe5e4 
Signed-off-by: Connor Baker <ConnorBaker01@gmail.com>
@ConnorBaker ConnorBaker self-assigned this Jul 3, 2025
@ConnorBaker ConnorBaker added 6.topic: cuda Parallel computing platform and API backport release-25.05 labels Jul 3, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 6.topic: cuda Parallel computing platform and API labels Jul 3, 2025
@ConnorBaker
Copy link
Contributor Author

ConnorBaker commented Jul 3, 2025 •
edited
Loading

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 422208
Commit: f4fe5e45a0e7248abe2ff45129c68e128731c8ea

x86_64-linux

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 422208 --package opencv.passthru.tests
Commit: f4fe5e45a0e7248abe2ff45129c68e128731c8ea

x86_64-linux

✅ 10 packages built:
  • opencv.passthru.tests.gst-plugins-bad
  • opencv.passthru.tests.gst-plugins-bad.dev (opencv.passthru.tests.gst-plugins-bad.dev.dev)
  • opencv.passthru.tests.opencv4-tests
  • opencv.passthru.tests.pythonEnabled
  • opencv.passthru.tests.pythonEnabled.cxxdev (opencv.passthru.tests.pythonEnabled.cxxdev.cxxdev, opencv.passthru.tests.pythonEnabled.cxxdev.package_tests)
  • opencv.passthru.tests.pythonEnabled.package_tests (opencv.passthru.tests.pythonEnabled.package_tests.cxxdev, opencv.passthru.tests.pythonEnabled.package_tests.package_tests)
  • opencv.passthru.tests.qimgv
  • opencv.passthru.tests.withIpp
  • opencv.passthru.tests.withIpp.cxxdev (opencv.passthru.tests.withIpp.cxxdev.cxxdev, opencv.passthru.tests.withIpp.cxxdev.package_tests)
  • opencv.passthru.tests.withIpp.package_tests (opencv.passthru.tests.withIpp.package_tests.cxxdev, opencv.passthru.tests.withIpp.package_tests.package_tests)

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 422208 --extra-nixpkgs-config '{ allowAliases = false; allowBroken = false; allowUnfree = true; checkMeta = true; contentAddressedByDefault = false; cudaCapabilities = [ "8.9" ]; cudaSupport = true; }'
Commit: f4fe5e45a0e7248abe2ff45129c68e128731c8ea

x86_64-linux

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 422208 --extra-nixpkgs-config '{ allowAliases = false; allowBroken = false; allowUnfree = true; checkMeta = true; contentAddressedByDefault = false; cudaCapabilities = [ "8.9" ]; cudaSupport = true; }' --package opencv.passthru.tests
Commit: f4fe5e45a0e7248abe2ff45129c68e128731c8ea

x86_64-linux

✅ 11 packages built:
  • opencv.passthru.tests.gst-plugins-bad
  • opencv.passthru.tests.gst-plugins-bad.dev (opencv.passthru.tests.gst-plugins-bad.dev.dev)
  • opencv.passthru.tests.no-libstdcxx-errors
  • opencv.passthru.tests.opencv4-tests
  • opencv.passthru.tests.pythonEnabled
  • opencv.passthru.tests.pythonEnabled.cxxdev (opencv.passthru.tests.pythonEnabled.cxxdev.cxxdev, opencv.passthru.tests.pythonEnabled.cxxdev.package_tests)
  • opencv.passthru.tests.pythonEnabled.package_tests (opencv.passthru.tests.pythonEnabled.package_tests.cxxdev, opencv.passthru.tests.pythonEnabled.package_tests.package_tests)
  • opencv.passthru.tests.qimgv
  • opencv.passthru.tests.withIpp
  • opencv.passthru.tests.withIpp.cxxdev (opencv.passthru.tests.withIpp.cxxdev.cxxdev, opencv.passthru.tests.withIpp.cxxdev.package_tests)
  • opencv.passthru.tests.withIpp.package_tests (opencv.passthru.tests.withIpp.package_tests.cxxdev, opencv.passthru.tests.withIpp.package_tests.package_tests)

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 422208
Commit: f4fe5e45a0e7248abe2ff45129c68e128731c8ea

aarch64-linux

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 422208 --package opencv.passthru.tests
Commit: f4fe5e45a0e7248abe2ff45129c68e128731c8ea

aarch64-linux

✅ 7 packages built:
  • opencv.passthru.tests.gst-plugins-bad
  • opencv.passthru.tests.gst-plugins-bad.dev (opencv.passthru.tests.gst-plugins-bad.dev.dev)
  • opencv.passthru.tests.opencv4-tests
  • opencv.passthru.tests.pythonEnabled
  • opencv.passthru.tests.pythonEnabled.cxxdev (opencv.passthru.tests.pythonEnabled.cxxdev.cxxdev, opencv.passthru.tests.pythonEnabled.cxxdev.package_tests)
  • opencv.passthru.tests.pythonEnabled.package_tests (opencv.passthru.tests.pythonEnabled.package_tests.cxxdev, opencv.passthru.tests.pythonEnabled.package_tests.package_tests)
  • opencv.passthru.tests.qimgv

@ConnorBaker ConnorBaker moved this from New to 👀 Awaits reviews in CUDA Team Jul 3, 2025
@ConnorBaker ConnorBaker added the 6.topic: cuda Parallel computing platform and API label Jul 3, 2025
@ConnorBaker ConnorBaker mentioned this pull request Jul 3, 2025
Merged
13 tasks
@ConnorBaker ConnorBaker requested a review from philiptaron July 16, 2025 06:35
@ConnorBaker
Copy link
Contributor Author

ConnorBaker commented Jul 16, 2025

Ping @basvandijk any chance you'd be able to review this?

philiptaron
philiptaron approved these changes Jul 16, 2025
View reviewed changes
Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.

@philiptaron
Copy link
Contributor

philiptaron commented Jul 16, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 422208 --package opencv.tests
Commit: f4fe5e45a0e7248abe2ff45129c68e128731c8ea

x86_64-linux

✅ 10 packages built:
  • opencv.tests.gst-plugins-bad
  • opencv.tests.gst-plugins-bad.dev (opencv.tests.gst-plugins-bad.dev.dev)
  • opencv.tests.opencv4-tests
  • opencv.tests.pythonEnabled
  • opencv.tests.pythonEnabled.cxxdev (opencv.tests.pythonEnabled.cxxdev.cxxdev, opencv.tests.pythonEnabled.cxxdev.package_tests)
  • opencv.tests.pythonEnabled.package_tests (opencv.tests.pythonEnabled.package_tests.cxxdev, opencv.tests.pythonEnabled.package_tests.package_tests)
  • opencv.tests.qimgv
  • opencv.tests.withIpp
  • opencv.tests.withIpp.cxxdev (opencv.tests.withIpp.cxxdev.cxxdev, opencv.tests.withIpp.cxxdev.package_tests)
  • opencv.tests.withIpp.package_tests (opencv.tests.withIpp.package_tests.cxxdev, opencv.tests.withIpp.package_tests.package_tests)

@philiptaron philiptaron merged commit ae5287b into NixOS:master Jul 16, 2025
35 of 36 checks passed
@github-project-automation github-project-automation bot moved this from 👀 Awaits reviews to ✅ Done in CUDA Team Jul 16, 2025
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jul 16, 2025

Successfully created backport PR for release-25.05:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Jul 16, 2025
Merged
1 task
@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jul 16, 2025
@ConnorBaker ConnorBaker deleted the fix/opencv-cuda-tests branch July 16, 2025 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philiptaron philiptaron philiptaron approved these changes

@Stunkymonkey Stunkymonkey Awaiting requested review from Stunkymonkey

@FliegendeWurst FliegendeWurst Awaiting requested review from FliegendeWurst

@basvandijk basvandijk Awaiting requested review from basvandijk

@SomeoneSerge SomeoneSerge Awaiting requested review from SomeoneSerge

Assignees

@ConnorBaker ConnorBaker

Labels

6.topic: cuda Parallel computing platform and API 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

CUDA Team
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ConnorBaker @philiptaron