Skip to content

snes9x-gtk: Install normally#42213

Merged
adisbladis merged 1 commit intomasterfrom
unknown repository
Jun 19, 2018
Merged

snes9x-gtk: Install normally#42213
adisbladis merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Jun 19, 2018

Motivation for this change

/share was not installed before, thus missing the desktop file.
Added wrapGAppsHook so the executable will know how to handle certain GTK things.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 19, 2018
@adisbladis adisbladis merged commit 119b41f into NixOS:master Jun 19, 2018
@adisbladis
Copy link
Member

Thanks!

@ghost ghost deleted the dev/snes9x branch June 19, 2018 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants