Skip to content

Comments

util-linuxMinimal: use fetchurlBoot#422014

Merged
numinit merged 1 commit intoNixOS:masterfrom
numinit:util-linux/fetchurlBoot
Jul 20, 2025
Merged

util-linuxMinimal: use fetchurlBoot#422014
numinit merged 1 commit intoNixOS:masterfrom
numinit:util-linux/fetchurlBoot

Conversation

@numinit
Copy link
Contributor

@numinit numinit commented Jul 3, 2025

Use fetchurlBoot for util-linuxMinimal. The dependency chain goes something like:

util-linuxMinimal -> fetchurl -> nss-cacert -> python3.13-buildcatrust -> python3, which causes infinite recursion if
a hash is left out. So override fetchurl to fetchurlBoot just for the minimal util-linux.

This was reproducible if the hash in fetchurl was left blank so it needed to be evaluated.


Didn't seem to happen in 24.11, seems to happen in 25.05.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

The dependency chain goes something like:

util-linuxMinimal -> fetchurl -> nss-cacert -> \
python3.13-buildcatrust -> python3 which causes infinite recursion if
a hash is left out. So override fetchurl to fetchurlBoot just for the
minimal util-linux.
@numinit numinit force-pushed the util-linux/fetchurlBoot branch from b66d454 to c897b56 Compare July 3, 2025 08:51
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jul 3, 2025
@numinit numinit mentioned this pull request Jul 19, 2025
13 tasks
@numinit numinit requested a review from MisileLab July 19, 2025 18:55
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jul 19, 2025
@numinit numinit requested a review from RossComputerGuy July 20, 2025 03:43
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 20, 2025
@numinit numinit merged commit 838a935 into NixOS:master Jul 20, 2025
30 of 31 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jul 20, 2025

Successfully created backport PR for release-25.05:

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jul 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants