util-linux, kubernetes, k3s: drop util-linux.withPatches#421985
Merged
numinit merged 3 commits intoNixOS:masterfrom Jul 5, 2025
Merged
util-linux, kubernetes, k3s: drop util-linux.withPatches#421985numinit merged 3 commits intoNixOS:masterfrom
numinit merged 3 commits intoNixOS:masterfrom
Conversation
This, and commits to k3s and util-linux close NixOS#409339. The util-linux.withPatches API was a temporary hack for the 25.05 release to fix Kubernetes, and is going away. While we're at it, we should use util-linuxMinimal because we do not need things such as systemd support for kubelet initialization.
This, as well as commits to kubernetes and util-linux, close NixOS#409339. util-linux.withPatches was a temporary hack to unbreak Kubernetes for the 25.05 release.
Closes NixOS#409339. This API was intended to be a temporary hack to fix Kubernetes and other consumers that relied on this specific util-linux mount behavior. Now that util-linux is correctly patched, we can drop this passthru.
Contributor
Author
|
Checked by running the passthru tests, all work. |
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
4 tasks
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/solved-downgrade-dependency-to-util-linux-in-a-remote-flake/65132/7 |
Contributor
Author
|
Really this passthru should have been called |
alyssais
reviewed
Jul 3, 2025
alyssais
approved these changes
Jul 3, 2025
nixpkgs-ci
bot
added
the
12.approvals: 1
rorosen
approved these changes
Jul 3, 2025
nixpkgs-ci
bot
added
12.approvals: 2
Contributor
|
Successfully created backport PR for |
github-actions
bot
added
the
8.has: port to stable
1 task
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #409339. This API was intended to be a temporary hack to fix Kubernetes and other consumers that relied on this specific util-linux mount behavior. Now that util-linux is correctly patched, we can drop this passthru.
cc: @NixOS/kubernetes @NixOS/k3s @DerRockWolf
This should be backported since #411662 was the equivalent for 25.05:
https://nixpk.gs/pr-tracker.html?pr=411662
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.