Skip to content

nixos-18.03/pgbackup: Fix bug in postgresql-backup module that causes to fail#42182

Merged
Mic92 merged 1 commit intoNixOS:release-18.03from
markuskowa:pgbackup-18.03
Jun 19, 2018
Merged

nixos-18.03/pgbackup: Fix bug in postgresql-backup module that causes to fail#42182
Mic92 merged 1 commit intoNixOS:release-18.03from
markuskowa:pgbackup-18.03

Conversation

@markuskowa
Copy link
Member

Motivation for this change

The postgresqlBackup module fails to backup the database.
User root is ignored and pg_dump does not create a backup (at least in newer postgres version?).
See #41388

This is a hotfix for 18.03. See #42133 for a more thorough
refactoring of the postgresqlBackup module.

Things done

Run pg_dump as postgres super user instead of root. Otherwise

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

pg_dump to fail

Run pg_dump as postgres super user instead of root.
See NixOS#41388
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 18, 2018
@Mic92 Mic92 merged commit 43d3e53 into NixOS:release-18.03 Jun 19, 2018
@markuskowa markuskowa deleted the pgbackup-18.03 branch June 20, 2018 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants