nixos-18.03/pgbackup: Fix bug in postgresql-backup module that causes to fail#42182
Merged
Mic92 merged 1 commit intoNixOS:release-18.03from Jun 19, 2018
Merged
nixos-18.03/pgbackup: Fix bug in postgresql-backup module that causes to fail#42182Mic92 merged 1 commit intoNixOS:release-18.03from
Mic92 merged 1 commit intoNixOS:release-18.03from
Conversation
pg_dump to fail Run pg_dump as postgres super user instead of root. See NixOS#41388
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The
postgresqlBackupmodule fails to backup the database.User
rootis ignored and pg_dump does not create a backup (at least in newer postgres version?).See #41388
This is a hotfix for 18.03. See #42133 for a more thorough
refactoring of the
postgresqlBackupmodule.Things done
Run pg_dump as postgres super user instead of root. Otherwise
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)