Skip to content

tree-sitter: unbreak, remove useFetchCargoVendor#421659

Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom
dtomvan:dtomvan/push-rlklptnroxsp
Jul 6, 2025
Merged

tree-sitter: unbreak, remove useFetchCargoVendor#421659
vcunat merged 1 commit intoNixOS:staging-nextfrom
dtomvan:dtomvan/push-rlklptnroxsp

Conversation

@dtomvan
Copy link
Contributor

@dtomvan dtomvan commented Jul 2, 2025

Fix #414233 (comment)

After a quite lengthy staging build (including llvm and stuff... ugh...) this time I can quite confidently say the build is working again.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. labels Jul 2, 2025
@nix-owners nix-owners bot requested review from Profpatsch and uncenter July 2, 2025 01:27
@uncenter
Copy link
Member

uncenter commented Jul 2, 2025

Built locally with nix-build -A tree-sitter, functionality (generate) tested.

@uncenter uncenter added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 2, 2025
@nixpkgs-ci nixpkgs-ci bot added the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. label Jul 2, 2025
@mweinelt
Copy link
Member

mweinelt commented Jul 6, 2025

Needs to target staging-next. cc #422427

@vcunat vcunat changed the base branch from staging to staging-next July 6, 2025 07:01
@nixpkgs-ci nixpkgs-ci bot closed this Jul 6, 2025
@nixpkgs-ci nixpkgs-ci bot reopened this Jul 6, 2025
@vcunat vcunat merged commit 1fbb635 into NixOS:staging-next Jul 6, 2025
46 of 51 checks passed
@dtomvan dtomvan deleted the dtomvan/push-rlklptnroxsp branch July 6, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants