Skip to content

Comments

nixos-render-docs: fix path for redirects.js#421500

Merged
fricklerhandwerk merged 1 commit intoNixOS:masterfrom
Prince213:push-uxrxsxlqlpsk
Jul 1, 2025
Merged

nixos-render-docs: fix path for redirects.js#421500
fricklerhandwerk merged 1 commit intoNixOS:masterfrom
Prince213:push-uxrxsxlqlpsk

Conversation

@Prince213
Copy link
Member

Currently we use the store path for referencing redirects.js which won't work:

<script src="/nix/store/f8bmfn7lm02s73ar35ya2l9qdwv2mn39-nixos-manual-html/share/doc/nixos/index-redirects.js" type="text/javascript"></script>

Instead reference it like other scripts with relative paths:

<script src="./index-redirects.js" type="text/javascript"></script>

This fixes redirects for the NixOS manual.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Jul 1, 2025
@fricklerhandwerk
Copy link
Contributor

Thanks a lot!

@fricklerhandwerk fricklerhandwerk merged commit ec49bcd into NixOS:master Jul 1, 2025
26 of 29 checks passed
@Prince213
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants