libgcrypt: fix bad locking behavior introduced in update#42150
libgcrypt: fix bad locking behavior introduced in update#42150dtzWill merged 3 commits intoNixOS:stagingfrom
Conversation
|
Success on x86_64-linux (full log) Attempted: libgcrypt Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: libgcrypt Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: libgcrypt Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: libgcrypt Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: libgcrypt Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: libgcrypt Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: libgcrypt Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: libgcrypt Partial log (click to expand)
|
|
Looks like yes hangs w/o the patch--time to reconfirm with patch once timeout triggers! Well, force-pushing it now hopefully the timeout result isn't too confusing when it completes :). |
f5fe6a9 to
bb90cbf
Compare
|
Failure on x86_64-darwin (full log) Attempted: libgcrypt Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: libgcrypt Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: libgcrypt Partial log (click to expand)
|
|
Woohoo! 😁 Sent email to upstream mailing list, pending moderator approval I think. |
|
Success on aarch64-linux (full log) Attempted: libgcrypt Partial log (click to expand)
|
|
I suppose this should go to staging first due to mass-rebuilds... |
|
...But that's messy because staging doesn't have the commit from master/18.03 that disables tests that this fixes. Blargh. |
|
@dtzWill let's merge master into staging first then. |
Yes please! |
|
Targeting staging now, think this is good to go? |
|
@GrahamcOfBorg build libgcrypt |
|
Success on x86_64-linux (full log) Attempted: libgcrypt Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: libgcrypt Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: libgcrypt Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: libgcrypt Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: libgcrypt Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: libgcrypt Partial log (click to expand)
|
As-is this hangs on musl (and possibly cause of Darwin hangs)
due to trying to obtain non-recursive lock already held.
Especially if this seems to fix hanging problems on Darwin,
will be reporting upstream.
Probably should wait until that happens or this is
otherwise investigated further.
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)