python3Packages.{libcomps,libdnf,libmodulemd}: remove overrideAttrs#421212
Open
LordGrimmauld wants to merge 3 commits intoNixOS:masterfrom
Open
python3Packages.{libcomps,libdnf,libmodulemd}: remove overrideAttrs#421212LordGrimmauld wants to merge 3 commits intoNixOS:masterfrom
LordGrimmauld wants to merge 3 commits intoNixOS:masterfrom
Conversation
LordGrimmauld
force-pushed
the
overrideAttrs-python-packages
branch
from
9b11642 to
6a19a33
Compare
LordGrimmauld
changed the title
nixpkgs-ci
bot
added
10.rebuild-linux: 11-100
dotlambda
reviewed
Jun 30, 2025
Member
There was a problem hiding this comment.
Suggested change
| withPython ? true, |
What's the point?
Contributor
Author
There was a problem hiding this comment.
The fact the python package was only marked broken conditionally suggests there is people that used unsupported interpretters, e.g. by global override. I intended to give an escape hatch to avoid the meta.broken in cases where no suitable interpreter is available, kinda how the non-python-package never was marked broken before, independent of passed python3.
Contributor
Author
There was a problem hiding this comment.
Eh, probably not worth, removed.
LordGrimmauld
force-pushed
the
overrideAttrs-python-packages
branch
from
6a19a33 to
d48981a
Compare
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
nixpkgs-ci
bot
added
the
2.status: stale
qweered
approved these changes
Dec 28, 2025
nixpkgs-ci
bot
added
12.approvals: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
overrideAttrshas some weird behavior, with some contributors working on reducing usage of it (see #421201).The previous
lib.pipeusage was all wonky, causing double-overrides and unreadable definitions.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.