libmtp: fix built against gettext-0.25#421167
Merged
alyssais merged 1 commit intoNixOS:stagingfrom Jul 2, 2025
Merged
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 101-500
alyssais
reviewed
Jun 30, 2025
pkgs/by-name/li/libmtp/package.nix
Outdated
Member
There was a problem hiding this comment.
Usually we'd write this on multiple lines…
Contributor
Author
There was a problem hiding this comment.
Sounds good. Switched to command per line
Without the change the build fails as:
configure.ac:265: the top level
configure:14220: error: possibly undefined macro: AC_LIB_PREPARE_PREFIX
If this token and others are legitimate, please use m4_pattern_allow.
See the Autoconf documentation.
trofi
force-pushed
the
libmtp-gettext-0.25
branch
from
4fe4a19 to
415af28
Compare
alyssais
approved these changes
Jun 30, 2025
nixpkgs-ci
bot
added
the
12.approvals: 1
Member
|
@ofborg build libmtp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the change the build fails as:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.